[MRG] Add whats_new about fixing example #7184

Merged
merged 3 commits into from Aug 13, 2016

Conversation

Projects
None yet
4 participants
@yenchenlin
Contributor

yenchenlin commented Aug 12, 2016

This PR adds bug fixed in #7170 to whats_new.rst.

Sorry for not doing it in the same commit.

pint @jnothman

doc/whats_new.rst
@@ -325,6 +325,10 @@ Bug fixes
(`#7101 <https://github.com/scikit-learn/scikit-learn/pull/7101>`_)
By `Ibraim Ganiev`_.
+ - :func:`silhouette_score` now supports sparse input, and this also fixes
+ `example_gaussian_process_plot_gp_regression.py`.

This comment has been minimized.

@nelson-liu

nelson-liu Aug 12, 2016

Contributor

double backticks?

@nelson-liu

nelson-liu Aug 12, 2016

Contributor

double backticks?

This comment has been minimized.

@yenchenlin

yenchenlin Aug 13, 2016

Contributor

Base on other lines, it seems backticks are not needed. thanks! 😄

@yenchenlin

yenchenlin Aug 13, 2016

Contributor

Base on other lines, it seems backticks are not needed. thanks! 😄

doc/whats_new.rst
@@ -325,6 +325,10 @@ Bug fixes
(`#7101 <https://github.com/scikit-learn/scikit-learn/pull/7101>`_)
By `Ibraim Ganiev`_.
+ - :func:`silhouette_score` now supports sparse input, and this also fixes
+ examples/text/document_clustering.py.
+ By `YenChen Lin`_.

This comment has been minimized.

@agramfort

agramfort Aug 13, 2016

Member

you mix up an enhancement and a bug fix

@agramfort

agramfort Aug 13, 2016

Member

you mix up an enhancement and a bug fix

This comment has been minimized.

@yenchenlin

yenchenlin Aug 13, 2016

Contributor

ooops, sorry!

So should I split silhouette_score part into enhancement, and example part into bug fix?

@yenchenlin

yenchenlin Aug 13, 2016

Contributor

ooops, sorry!

So should I split silhouette_score part into enhancement, and example part into bug fix?

This comment has been minimized.

@jnothman

jnothman Aug 13, 2016

Member

It is a bug fix. It's fixing a regression. So it's the wording that's wrong.

@jnothman

jnothman Aug 13, 2016

Member

It is a bug fix. It's fixing a regression. So it's the wording that's wrong.

This comment has been minimized.

@jnothman

jnothman Aug 13, 2016

Member

Need to express that it again support sparse input.

@jnothman

jnothman Aug 13, 2016

Member

Need to express that it again support sparse input.

This comment has been minimized.

@yenchenlin

yenchenlin Aug 13, 2016

Contributor

My bad ... again added.

@yenchenlin

yenchenlin Aug 13, 2016

Contributor

My bad ... again added.

@agramfort

This comment has been minimized.

Show comment
Hide comment
@agramfort

agramfort Aug 13, 2016

Member

ok merging. I'll rephrase in master. thx @yenchenlin

Member

agramfort commented Aug 13, 2016

ok merging. I'll rephrase in master. thx @yenchenlin

@agramfort agramfort merged commit 7b3c467 into scikit-learn:master Aug 13, 2016

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yenchenlin

This comment has been minimized.

Show comment
Hide comment
@yenchenlin

yenchenlin Aug 13, 2016

Contributor

@agramfort thanks for the help 😭

Contributor

yenchenlin commented Aug 13, 2016

@agramfort thanks for the help 😭

TomDLT added a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016

[MRG] Add whats_new about fixing example (#7184)
* Add whats_new

* Fix typo

* Fix wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment