Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG] Add DCG and NDCG #7739
DCG and NDCG implementation. Issue #2805
What does this implement/fix? Explain your changes.
Add two scores,
Any other comments?
As a first time collaborator, let me know if I should add or change something!
Hey there @TomDLT! Thanks a lot for this useful tips for someone like me! I've tried to fix and improve the implementation a bit. I still have to:
Again, I'd appreciate a lot if you want to let me know anything that I could improve. Thanks again!
Thanks for the update, it looks much better!
You have to fix your unit test, it's failing.
Can you also add a small text on the documentation (
doc/modules/model_evaluation.rst, in the ranking section), with the maths formula and explaining when these metrics should be used.
Just pushed another series of small commits @TomDLT!
Not sure if I'm the best one to do that as I've only used it once and briefly!