[MRG + 1] MAINT: Return self for fit in Spectral Biclustering and CoClustering #7814
Conversation
sklearn/cluster/bicluster.py
Outdated
| """ | ||
| X = check_array(X, accept_sparse='csr', dtype=np.float64) | ||
| self._check_parameters() | ||
| self._fit(X) | ||
| return self._fit(X) |
raghavrv
Nov 3, 2016
Member
simply return self and don't touch self._fit(X)?
simply return self and don't touch self._fit(X)?
raghavrv
changed the title
|
Besides LGTM. |
|
Thanks for the review @raghavrv . It now returns |
|
Thanks @maniteja123 |
amueller
added a commit
to amueller/scikit-learn
that referenced
this pull request
Nov 9, 2016
sergeyf
added a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
afiodorov
added a commit
to unravelin/scikit-learn
that referenced
this pull request
Apr 25, 2017
Sundrique
added a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
paulha
added a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
added a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Regarding gh-6126
Fix
fitmethod to returnselfforSpectralBiclusteringandSpectralCoclustering, but the common tests still skip the bicluster classes.This is a temporary fix for 0.18.1 and will try to make the common tests as part of gh-6141.