Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG + 1] MAINT: Return self for fit in Spectral Biclustering and CoClustering #7814

Merged
merged 2 commits into from Nov 3, 2016

Conversation

@maniteja123
Copy link
Contributor

@maniteja123 maniteja123 commented Nov 3, 2016

Regarding gh-6126

Fix fit method to return self for SpectralBiclustering and SpectralCoclustering, but the common tests still skip the bicluster classes.

This is a temporary fix for 0.18.1 and will try to make the common tests as part of gh-6141.

"""
X = check_array(X, accept_sparse='csr', dtype=np.float64)
self._check_parameters()
self._fit(X)
return self._fit(X)

This comment has been minimized.

@raghavrv

raghavrv Nov 3, 2016
Member

simply return self and don't touch self._fit(X)?

@raghavrv raghavrv changed the title [MRG] MAINT: Return self for fit in Spectral Biclustering and CoClustering [MRG + 1] MAINT: Return self for fit in Spectral Biclustering and CoClustering Nov 3, 2016
@raghavrv
Copy link
Member

@raghavrv raghavrv commented Nov 3, 2016

Besides LGTM.

@maniteja123
Copy link
Contributor Author

@maniteja123 maniteja123 commented Nov 3, 2016

Thanks for the review @raghavrv . It now returns self in fit itself. Hope it is fine now.

@jnothman jnothman merged commit bd911ec into scikit-learn:master Nov 3, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jnothman
Copy link
Member

@jnothman jnothman commented Nov 3, 2016

Thanks @maniteja123

@raghavrv raghavrv added this to the 0.18.1 milestone Nov 3, 2016
@raghavrv raghavrv added the Bug label Nov 3, 2016
amueller added a commit to amueller/scikit-learn that referenced this pull request Nov 9, 2016
sergeyf added a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
afiodorov added a commit to unravelin/scikit-learn that referenced this pull request Apr 25, 2017
Sundrique added a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
paulha added a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants