Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG+1] Fix estimators to work if sample_weight parameter is pandas Series type #7825
Finishes work in #5642
What does this implement/fix? Explain your changes.
This addresses the comments made on @pradyu1993's commit
Any other comments?
May still warrant a PEP8 linting. (Having trouble with my usual development machine so once I get back on that I'll run the linter & all). Let me know if there are any suggestions on tests or improvements to how the check is made. Thanks!
referenced this pull request
Nov 4, 2016
Travis is indeed reporting linter failures: https://travis-ci.org/scikit-learn/scikit-learn/jobs/173378047
Do you mean in functions like
Could you please also rename this to MRG if you think the work is complete enough for a full review.
I don't think ImportWarning is good as it's ignored by default.