Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

EasyFix: Merge SVM grid search and parameter explanation examples #851

Merged
merged 5 commits into from May 14, 2012

Conversation

Projects
None yet
2 participants
Contributor

duckworthd commented May 11, 2012

In fulfillment of #744 .

Deleted plot_svm_parameters_selection.py and merged its contents into plot_rbf_parameters.py. Reformatted plots to only make one figure and show the contents of both side-by-side.

Let me know if there's anything you'd like to see cleaned up.

@duckworthd duckworthd Merged svm parameter selection visualization
-deleted plot_svm_parameters_selection
-merged its contents into plot_rbf_parameters
e27b310
Owner

agramfort commented May 13, 2012

thanks for doing this.

You should use 2 figures rather than 1 very large.

Ideally the generated plots should appear in the doc.

I checked and it seems that the previously generated plots were not in the doc.

Contributor

duckworthd commented May 13, 2012

2 figures instead of 1? Sure, no problem.

"Ideally the generated plots should appear in the doc."

I'm not sure, they seemed to appear when I did a make html, but I'll try again.

Owner

agramfort commented May 13, 2012

2 figures instead of 1?  Sure, no problem.

yes

"Ideally the generated plots should appear in the doc."

I'm not sure, they seemed to appear when I did a make html, but I'll try again.

some images generated by examples are manually included in the doc. E.g.

.. figure:: ../auto_examples/svm/images/plot_iris_1.png
:target: ../auto_examples/svm/plot_iris.html
:align: center

in svm.rst

Contributor

duckworthd commented May 13, 2012

I've split the large figure into two and added a short sub-sub-section under the "Support Vector Machine" section of the documentation describing the RBF parameters and linking to the example. Let me know if there's anything else you would like to see.

Owner

agramfort commented May 14, 2012

.. _svm_mathematical_formulation: in svm.rst should be just before the Mathematical formulation section as it is the sphinx name for the section. Besides this +1 for merge

Contributor

duckworthd commented May 14, 2012

What a silly mistake. All fixed.

@agramfort agramfort added a commit that referenced this pull request May 14, 2012

@agramfort agramfort Merge pull request #851 from duckworthd/master
EasyFix: Merge SVM grid search and parameter explanation examples
dc86f0d

@agramfort agramfort merged commit dc86f0d into scikit-learn:master May 14, 2012

Owner

agramfort commented May 14, 2012

merged thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment