Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG] DOCATHON : LLE and Isomap match doc for sparse input #8554
Isomap does, in fact support sparse input. Code was changed to match the documentation, and a test was added to verify that it doesn't error.
LLE does not support sparse input -- the
Please use "Fix #issueNumber" this way the associated issue gets closed automatically when the PR is merged. For more details, look at this.
Note this pattern is not flexible so using "Fix issue #issueNumber" or "Fix for #issueNumber" is not going to work. I have edited your description.
I updated the docstrings to a version that seems to be the consensus, i.e. array-like or NearestNeighbors.
I quickly run the tests with a print statement and we do have tests for locally_linear_embedding that takes X as a NearestNeighbors object.
I have no idea about the CircleCI failure but I would just ignore this one.
@jnothman should we had a whats_new entry that says that Isomap can now fit a sparse matrix?