[MRG+1] GaussianProcessRegressor: faster prediction of std #8591

Merged
merged 2 commits into from Mar 16, 2017

Conversation

Projects
None yet
3 participants
@hbertrand
Contributor

hbertrand commented Mar 15, 2017

Reference Issue

None

What does this implement/fix? Explain your changes.

Predicting the std in GaussianProcessRegressor is very slow because of a particular np.einsum call. Simplifying the call gives the same result much faster.

Any other comments?

See this SO thread for a very similar situation solved the same way:
http://stackoverflow.com/questions/14758283/is-there-a-numpy-scipy-dot-product-calculating-only-the-diagonal-entries-of-the

See this gist for benchmarking:
https://gist.github.com/hbertrand/191f94fc2a7b2c14a6a6739e9a5afe45

Even for medium size matrix, the new call is over 10x faster.

@agramfort

This comment has been minimized.

Show comment
Hide comment
@agramfort

agramfort Mar 16, 2017

Member

LGTM

Member

agramfort commented Mar 16, 2017

LGTM

@agramfort agramfort changed the title from [MRG] GaussianProcessRegressor: faster prediction of std to [MRG+1] GaussianProcessRegressor: faster prediction of std Mar 16, 2017

@lesteve

This comment has been minimized.

Show comment
Hide comment
@lesteve

lesteve Mar 16, 2017

Member

LGTM, can you add an entry in doc/whats_new.rst?

Member

lesteve commented Mar 16, 2017

LGTM, can you add an entry in doc/whats_new.rst?

@hbertrand

This comment has been minimized.

Show comment
Hide comment
@hbertrand

hbertrand Mar 16, 2017

Contributor

Done :-)

Contributor

hbertrand commented Mar 16, 2017

Done :-)

@lesteve

This comment has been minimized.

Show comment
Hide comment
@lesteve

lesteve Mar 16, 2017

Member

Merging, thanks a lot!

Member

lesteve commented Mar 16, 2017

Merging, thanks a lot!

@lesteve lesteve merged commit d01a02b into scikit-learn:master Mar 16, 2017

1 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Przemo10 Przemo10 referenced this pull request Mar 17, 2017

Closed

update fork (#1) #8606

herilalaina added a commit to herilalaina/scikit-learn that referenced this pull request Mar 26, 2017

massich added a commit to massich/scikit-learn that referenced this pull request Apr 26, 2017

Sundrique added a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017

NelleV added a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017

paulha added a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment