[MRG+1] EHN add decimals parameter for export_graphviz

[glemaitre]

Reference Issue

Fixes #8662

What does this implement/fix? Explain your changes.

Introduce a parameter decimals to control decimal precision when displaying threshold, impurity, and value parameters in export_graphviz.

Any other comments?

[MechCoder]

That's it from me.

[MechCoder]

LGTM pending whatsnew

[MechCoder]

LGTM pending whatsnew

[glemaitre]

@MechCoder Done

[glemaitre]

@MechCoder Done

[MechCoder]

LGTM

[glemaitre]

@raghavrv ping Could you give a look?

[glemaitre]

@raghavrv ping Could you give a look?

[raghavrv]

Thanks!! A few questions. Otherwise LGTM

+1 for merge after refactoring the tests into a loop (if possible)

[jmschrei]

I can see a case being made for precision since that's what numpy uses in set_printoptions. I am neutral on it, as this isn't a big enough feature to warrant nit-picking. Once the checks are fixed, I am +1 as well.

[jmschrei]

I can see a case being made for precision since that's what numpy uses in set_printoptions. I am neutral on it, as this isn't a big enough feature to warrant nit-picking. Once the checks are fixed, I am +1 as well.

[glemaitre]

I first thought about decimals as in around, but the point of @jmschrei and @raghavrv is pertinent.

I made the changes

[glemaitre]

I first thought about decimals as in around, but the point of @jmschrei and @raghavrv is pertinent.

I made the changes

[jnothman]

pandas used precision too

…

On 28 Apr 2017 11:28 pm, "Guillaume Lemaitre" ***@***.***> wrote: I first thought about decimals as in around, but the point of @jmschrei <https://github.com/jmschrei> and @raghavrv <https://github.com/raghavrv> is pertinent. I made the changes — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8698 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEz6zfH6wJfIUtfo63vikBLU1-MOdJtks5r0elkgaJpZM4My8fh> .

[jnothman]

pandas used precision too

…

On 28 Apr 2017 11:28 pm, "Guillaume Lemaitre" ***@***.***> wrote: I first thought about decimals as in around, but the point of @jmschrei <https://github.com/jmschrei> and @raghavrv <https://github.com/raghavrv> is pertinent. I made the changes — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8698 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEz6zfH6wJfIUtfo63vikBLU1-MOdJtks5r0elkgaJpZM4My8fh> .

[glemaitre]

@jnothman ok so definitely precision makes sense. Then, it should be OK to be merged.

[glemaitre]

@jnothman ok so definitely precision makes sense. Then, it should be OK to be merged.

[raghavrv]

Thanks a lot... I'm merging this in!!

[raghavrv]

Thanks a lot... I'm merging this in!!

[ryanrozich]

Thanks!

[ryanrozich]

Thanks!