New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] EHN add decimals parameter for export_graphviz #8698

Merged
merged 7 commits into from Apr 29, 2017

Conversation

Projects
None yet
6 participants
@glemaitre
Contributor

glemaitre commented Apr 4, 2017

Reference Issue

Fixes #8662

What does this implement/fix? Explain your changes.

Introduce a parameter decimals to control decimal precision when displaying threshold, impurity, and value parameters in export_graphviz.

Any other comments?

Show outdated Hide outdated sklearn/tree/export.py
Show outdated Hide outdated sklearn/tree/tests/test_export.py
Show outdated Hide outdated sklearn/tree/tests/test_export.py
Show outdated Hide outdated sklearn/tree/tests/test_export.py

glemaitre added some commits Apr 22, 2017

@MechCoder

That's it from me.

Show outdated Hide outdated sklearn/tree/tests/test_export.py
Show outdated Hide outdated sklearn/tree/tests/test_export.py
Show outdated Hide outdated sklearn/tree/tests/test_export.py
@MechCoder

This comment has been minimized.

Show comment
Hide comment
@MechCoder

MechCoder Apr 22, 2017

Member

LGTM pending whatsnew

Member

MechCoder commented Apr 22, 2017

LGTM pending whatsnew

@glemaitre

This comment has been minimized.

Show comment
Hide comment
@glemaitre

glemaitre Apr 23, 2017

Contributor

@MechCoder Done

Contributor

glemaitre commented Apr 23, 2017

@MechCoder Done

@MechCoder

LGTM

@MechCoder MechCoder changed the title from [MRG] EHN add decimals parameter for export_graphviz to [MRG+1] EHN add decimals parameter for export_graphviz Apr 23, 2017

@glemaitre

This comment has been minimized.

Show comment
Hide comment
@glemaitre

glemaitre Apr 25, 2017

Contributor

@raghavrv ping Could you give a look?

Contributor

glemaitre commented Apr 25, 2017

@raghavrv ping Could you give a look?

@raghavrv

Thanks!! A few questions. Otherwise LGTM

+1 for merge after refactoring the tests into a loop (if possible)

Show outdated Hide outdated sklearn/tree/tests/test_export.py
Show outdated Hide outdated sklearn/tree/export.py
Show outdated Hide outdated sklearn/tree/export.py
Show outdated Hide outdated sklearn/tree/tests/test_export.py
@jmschrei

This comment has been minimized.

Show comment
Hide comment
@jmschrei

jmschrei Apr 28, 2017

Member

I can see a case being made for precision since that's what numpy uses in set_printoptions. I am neutral on it, as this isn't a big enough feature to warrant nit-picking. Once the checks are fixed, I am +1 as well.

Member

jmschrei commented Apr 28, 2017

I can see a case being made for precision since that's what numpy uses in set_printoptions. I am neutral on it, as this isn't a big enough feature to warrant nit-picking. Once the checks are fixed, I am +1 as well.

@glemaitre

This comment has been minimized.

Show comment
Hide comment
@glemaitre

glemaitre Apr 28, 2017

Contributor

I first thought about decimals as in around, but the point of @jmschrei and @raghavrv is pertinent.

I made the changes

Contributor

glemaitre commented Apr 28, 2017

I first thought about decimals as in around, but the point of @jmschrei and @raghavrv is pertinent.

I made the changes

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Apr 29, 2017

Member
Member

jnothman commented Apr 29, 2017

@glemaitre

This comment has been minimized.

Show comment
Hide comment
@glemaitre

glemaitre Apr 29, 2017

Contributor

@jnothman ok so definitely precision makes sense. Then, it should be OK to be merged.

Contributor

glemaitre commented Apr 29, 2017

@jnothman ok so definitely precision makes sense. Then, it should be OK to be merged.

@raghavrv raghavrv merged commit 00da9cc into scikit-learn:master Apr 29, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.52%)
Details
codecov/project 95.52% (+<.01%) compared to ee82c3f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raghavrv

This comment has been minimized.

Show comment
Hide comment
@raghavrv

raghavrv Apr 29, 2017

Member

Thanks a lot... I'm merging this in!!

Member

raghavrv commented Apr 29, 2017

Thanks a lot... I'm merging this in!!

@ryanrozich

This comment has been minimized.

Show comment
Hide comment
@ryanrozich

ryanrozich commented Apr 29, 2017

Thanks!

Sundrique added a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017

[MRG+1] EHN add decimals parameter for export_graphviz (#8698)
* EHN add decimals parameter for export_graphviz

* FIX address comments

* TST add test for classification

* TST/FIX address comments

* FIX comments raghav

dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

[MRG+1] EHN add decimals parameter for export_graphviz (#8698)
* EHN add decimals parameter for export_graphviz

* FIX address comments

* TST add test for classification

* TST/FIX address comments

* FIX comments raghav

dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

[MRG+1] EHN add decimals parameter for export_graphviz (#8698)
* EHN add decimals parameter for export_graphviz

* FIX address comments

* TST add test for classification

* TST/FIX address comments

* FIX comments raghav

NelleV added a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017

[MRG+1] EHN add decimals parameter for export_graphviz (#8698)
* EHN add decimals parameter for export_graphviz

* FIX address comments

* TST add test for classification

* TST/FIX address comments

* FIX comments raghav

paulha added a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017

[MRG+1] EHN add decimals parameter for export_graphviz (#8698)
* EHN add decimals parameter for export_graphviz

* FIX address comments

* TST add test for classification

* TST/FIX address comments

* FIX comments raghav

AishwaryaRK added a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017

[MRG+1] EHN add decimals parameter for export_graphviz (#8698)
* EHN add decimals parameter for export_graphviz

* FIX address comments

* TST add test for classification

* TST/FIX address comments

* FIX comments raghav

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

[MRG+1] EHN add decimals parameter for export_graphviz (#8698)
* EHN add decimals parameter for export_graphviz

* FIX address comments

* TST add test for classification

* TST/FIX address comments

* FIX comments raghav

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

[MRG+1] EHN add decimals parameter for export_graphviz (#8698)
* EHN add decimals parameter for export_graphviz

* FIX address comments

* TST add test for classification

* TST/FIX address comments

* FIX comments raghav
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment