Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Drop NumPy < 1.8 #8874

Merged
merged 17 commits into from Jun 7, 2017
Merged

[MRG+1] Drop NumPy < 1.8 #8874

merged 17 commits into from Jun 7, 2017

Conversation

@naoyak
Copy link
Contributor

@naoyak naoyak commented May 13, 2017

ref: #8810
mostly removing old backports from utils.fixes

@naoyak naoyak force-pushed the naoyak:numpy-deps branch 6 times, most recently from 7aa463b to 8d27a7c May 13, 2017
@naoyak naoyak changed the title [WIP] Drop NumPy < 1.8 Drop NumPy < 1.8 May 14, 2017
@naoyak naoyak changed the title Drop NumPy < 1.8 MAINT Drop NumPy < 1.8 May 14, 2017
@naoyak naoyak mentioned this pull request May 14, 2017
8 tasks done
@naoyak naoyak force-pushed the naoyak:numpy-deps branch from 9e0fe82 to d8aabc9 May 15, 2017
@naoyak naoyak force-pushed the naoyak:numpy-deps branch from d8aabc9 to f9f2d50 May 24, 2017
@lesteve
Copy link
Member

@lesteve lesteve commented Jun 1, 2017

Skimming this PR this looks good overall. Could you keep the numpy-related stuff only in this PR? I feel the review process will be easier this way.

@lesteve
Copy link
Member

@lesteve lesteve commented Jun 1, 2017

I'll start looking at #8854 first, which does the scipy-related removal/deprecation, and then tackle this one.

@naoyak
Copy link
Contributor Author

@naoyak naoyak commented Jun 1, 2017

Yeah, I figured it might be easier to get #8854 in and then rebase - doing these in parallel would create some merge conflicts.

@naoyak naoyak force-pushed the naoyak:numpy-deps branch 2 times, most recently from 60a0176 to 5ed68bc Jun 2, 2017
@naoyak naoyak closed this Jun 2, 2017
@naoyak naoyak reopened this Jun 2, 2017
@naoyak naoyak force-pushed the naoyak:numpy-deps branch 4 times, most recently from 9855d73 to 0434ea1 Jun 2, 2017
@naoyak naoyak changed the title MAINT Drop NumPy < 1.8 [MRG] Drop NumPy < 1.8 Jun 2, 2017
@naoyak
Copy link
Contributor Author

@naoyak naoyak commented Jun 2, 2017

Rebased and ready for review.

@naoyak naoyak closed this Jun 3, 2017
@naoyak naoyak reopened this Jun 3, 2017
@naoyak naoyak closed this Jun 4, 2017
@naoyak naoyak reopened this Jun 4, 2017
Copy link
Member

@jnothman jnothman left a comment

The changes LGTM though I've not checked for completeness

@jnothman jnothman changed the title [MRG] Drop NumPy < 1.8 [MRG+1] Drop NumPy < 1.8 Jun 4, 2017
@lesteve lesteve force-pushed the naoyak:numpy-deps branch from 9f3a6e9 to cbf197e Jun 7, 2017
@lesteve
Copy link
Member

@lesteve lesteve commented Jun 7, 2017

I am going to merge this one without waiting for AppVeyor.

Thanks a lot @naoyak !

@lesteve lesteve merged commit 6579220 into scikit-learn:master Jun 7, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@naoyak naoyak deleted the naoyak:numpy-deps branch Jun 10, 2017
Sundrique added a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
NelleV added a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
paulha added a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
AishwaryaRK added a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants