[MRG] Fix LassoCV cross validation split() call #8973

Merged
merged 3 commits into from Jun 7, 2017

Conversation

Projects
None yet
4 participants
@paulochf
Contributor

paulochf commented Jun 1, 2017

Reference Issue

Fixes #8426

What does this implement/fix? Explain your changes.

Added the missing y parameter that was causing the error TypeError: split() missing 1 required positional argument: 'y', and its non-regression test.

Any other comments?

Will be positively influenced by issue #8971.

@paulochf

This comment has been minimized.

Show comment
Hide comment
@paulochf

paulochf Jun 1, 2017

Contributor

This test failed, but it seems is not related to this PR.

Contributor

paulochf commented Jun 1, 2017

This test failed, but it seems is not related to this PR.

+
+ pipe = make_pipeline(
+ StandardScaler(),
+ LassoCV(cv=KFold(n_splits=5))

This comment has been minimized.

@agramfort

agramfort Jun 2, 2017

Member

this test would fail on master?

@agramfort

agramfort Jun 2, 2017

Member

this test would fail on master?

This comment has been minimized.

@raghavrv

raghavrv Jun 2, 2017

Member

it should be StratifiedKFold...

@raghavrv

raghavrv Jun 2, 2017

Member

it should be StratifiedKFold...

This comment has been minimized.

@paulochf

paulochf Jun 2, 2017

Contributor

Sorry, @raghavrv! My bad at pasting.

Fixed that, although I could not run tests locally today.

@paulochf

paulochf Jun 2, 2017

Contributor

Sorry, @raghavrv! My bad at pasting.

Fixed that, although I could not run tests locally today.

@raghavrv

Small change in the tests... Otherwise good for merge

+
+ pipe = make_pipeline(
+ StandardScaler(),
+ LassoCV(cv=KFold(n_splits=5))

This comment has been minimized.

@raghavrv

raghavrv Jun 2, 2017

Member

it should be StratifiedKFold...

@raghavrv

raghavrv Jun 2, 2017

Member

it should be StratifiedKFold...

+def test_lasso_cv_with_some_model_selection():
+ from sklearn.pipeline import make_pipeline
+ from sklearn.preprocessing import StandardScaler
+ from sklearn.model_selection import KFold

This comment has been minimized.

@raghavrv

raghavrv Jun 2, 2017

Member

StratifiedKFold

@raghavrv

raghavrv Jun 2, 2017

Member

StratifiedKFold

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Jun 7, 2017

Member

LGTM, thanks

Member

jnothman commented Jun 7, 2017

LGTM, thanks

@jnothman jnothman merged commit 0e4bdfd into scikit-learn:master Jun 7, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 94.88%)
Details
codecov/project 94.88% (+<.01%) compared to 7ce7134
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Sundrique added a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017

[MRG] Fix LassoCV cross validation split() call (#8973)
* Fixing cross validation split call in LassoCV

* Non-regression test for LassoCV cv.split check

* Fix typo KFold->StratifiedKFold
@paulochf

This comment has been minimized.

Show comment
Hide comment
@paulochf

paulochf Jun 14, 2017

Contributor

Thank you for your help! Learnt a lot doing this, and happy for detecting the problem issue 8971 is going to solve.

Contributor

paulochf commented Jun 14, 2017

Thank you for your help! Learnt a lot doing this, and happy for detecting the problem issue 8971 is going to solve.

dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

[MRG] Fix LassoCV cross validation split() call (#8973)
* Fixing cross validation split call in LassoCV

* Non-regression test for LassoCV cv.split check

* Fix typo KFold->StratifiedKFold

dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

[MRG] Fix LassoCV cross validation split() call (#8973)
* Fixing cross validation split call in LassoCV

* Non-regression test for LassoCV cv.split check

* Fix typo KFold->StratifiedKFold

NelleV added a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017

[MRG] Fix LassoCV cross validation split() call (#8973)
* Fixing cross validation split call in LassoCV

* Non-regression test for LassoCV cv.split check

* Fix typo KFold->StratifiedKFold

paulha added a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017

[MRG] Fix LassoCV cross validation split() call (#8973)
* Fixing cross validation split call in LassoCV

* Non-regression test for LassoCV cv.split check

* Fix typo KFold->StratifiedKFold

AishwaryaRK added a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017

[MRG] Fix LassoCV cross validation split() call (#8973)
* Fixing cross validation split call in LassoCV

* Non-regression test for LassoCV cv.split check

* Fix typo KFold->StratifiedKFold

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

[MRG] Fix LassoCV cross validation split() call (#8973)
* Fixing cross validation split call in LassoCV

* Non-regression test for LassoCV cv.split check

* Fix typo KFold->StratifiedKFold

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

[MRG] Fix LassoCV cross validation split() call (#8973)
* Fixing cross validation split call in LassoCV

* Non-regression test for LassoCV cv.split check

* Fix typo KFold->StratifiedKFold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment