Join GitHub today
[MRG] Updated plot_stock_market.py to use Google Finance #9010
What does this implement/fix? Explain your changes.
This PR replaces a dependency on
The implementations is intentionally very basic not to distract the users
Any other comments?
I had to remove some symbols because the have no data on Google for
The code itself and the new plot look good to me. We still have similar clusters, e.g., most of the defense contractors.
I think the only question is whether we need to cache the data or not, probably only for the sake of CI. If so, we might as well add the downloader to the datasets module...
The example takes ~20s to run on my laptop, including download, so my take on it is not to bother about these aspects.