Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG+1] Take over PR #7647 - Add a "filename" attribute to datasets that have a CSV file #9101
Reference Issue: #7627
What does this implement/fix? Explain your changes.
(original PR description)
Any other comments?
changed the title from
[MRG] Take over PR #7647
[MRG] Take over PR #7647 - Add a "filename" attribute to datasets that have a CSV file
Jun 10, 2017
Looks good. I think this is an improvement, though it kind of feels odd that you're loading the data twice: once in load_X to create the datasets, and then again using the filename. I feel it would be more natural to not load the data just to get the file name.
So lgtm apart from the minor docstring nitpick.
Dec 4, 2017
6 checks passed
Congrats, @maskani-moh! But argh! With all those versionaddeds, we forgot to mention this in the change logs. Would you like to submit another small PR? Please add an entry to the change log at