New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+2] algorithm='auto' should always work for nearest neighbors (continuation) #9145

Merged
merged 9 commits into from Jun 19, 2017

Conversation

Projects
None yet
4 participants
@herilalaina
Contributor

herilalaina commented Jun 17, 2017

Reference Issue

Fixes #4931, continuation of #5596

What does this implement/fix? Explain your changes.

Implement test for metric in ['mahalanobis', 'wminkowski', 'seuclidean']

Any other comments?

Should we warn the user when the algorithm is set into brute? (instead of auto)

@herilalaina herilalaina changed the title from [WIP] algorithm='auto' should always work for nearest neighbors (continuation) to [MRG] algorithm='auto' should always work for nearest neighbors (continuation) Jun 17, 2017

@jnothman

otherwise LGTM

Show outdated Hide outdated sklearn/neighbors/tests/test_neighbors.py
Show outdated Hide outdated sklearn/neighbors/tests/test_neighbors.py
Show outdated Hide outdated sklearn/neighbors/tests/test_neighbors.py
Show outdated Hide outdated doc/modules/neighbors.rst
@herilalaina

This comment has been minimized.

Show comment
Hide comment
@herilalaina

herilalaina Jun 17, 2017

Contributor

Thanks for the review. The change has been done!

Contributor

herilalaina commented Jun 17, 2017

Thanks for the review. The change has been done!

@jnothman jnothman changed the title from [MRG] algorithm='auto' should always work for nearest neighbors (continuation) to [MRG+1] algorithm='auto' should always work for nearest neighbors (continuation) Jun 17, 2017

@jnothman jnothman added this to the 0.19 milestone Jun 18, 2017

rename _metrics to require_params, add set assert
Checking that the test is non-empty, and more didactic variable name

@amueller amueller changed the title from [MRG+1] algorithm='auto' should always work for nearest neighbors (continuation) to [MRG+2] algorithm='auto' should always work for nearest neighbors (continuation) Jun 19, 2017

@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Jun 19, 2017

Member

LGTM, I made minor minor changes to fix my nitpicks, merge on green.

Member

amueller commented Jun 19, 2017

LGTM, I made minor minor changes to fix my nitpicks, merge on green.

@herilalaina

This comment has been minimized.

Show comment
Hide comment
@herilalaina

herilalaina Jun 19, 2017

Contributor

Thank you!

Contributor

herilalaina commented Jun 19, 2017

Thank you!

@amueller amueller merged commit 60deaea into scikit-learn:master Jun 19, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@herilalaina herilalaina deleted the herilalaina:iss4931 branch Jun 19, 2017

dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

[MRG+2] algorithm='auto' should always work for nearest neighbors (co…
…ntinuation) (scikit-learn#9145)

* Merge neighbors.rst

* issue scikit-learn#4931

* Improve test implementation

* Update base.py

* Remove unused import

* Customize test for precomputed metric

* Change test function name

* rename _metrics to require_params, add set assert

Checking that the test is non-empty, and more didactic variable name

* Remove blank line

dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

[MRG+2] algorithm='auto' should always work for nearest neighbors (co…
…ntinuation) (scikit-learn#9145)

* Merge neighbors.rst

* issue scikit-learn#4931

* Improve test implementation

* Update base.py

* Remove unused import

* Customize test for precomputed metric

* Change test function name

* rename _metrics to require_params, add set assert

Checking that the test is non-empty, and more didactic variable name

* Remove blank line

NelleV added a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017

[MRG+2] algorithm='auto' should always work for nearest neighbors (co…
…ntinuation) (scikit-learn#9145)

* Merge neighbors.rst

* issue scikit-learn#4931

* Improve test implementation

* Update base.py

* Remove unused import

* Customize test for precomputed metric

* Change test function name

* rename _metrics to require_params, add set assert

Checking that the test is non-empty, and more didactic variable name

* Remove blank line

paulha added a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017

[MRG+2] algorithm='auto' should always work for nearest neighbors (co…
…ntinuation) (scikit-learn#9145)

* Merge neighbors.rst

* issue scikit-learn#4931

* Improve test implementation

* Update base.py

* Remove unused import

* Customize test for precomputed metric

* Change test function name

* rename _metrics to require_params, add set assert

Checking that the test is non-empty, and more didactic variable name

* Remove blank line

AishwaryaRK added a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017

[MRG+2] algorithm='auto' should always work for nearest neighbors (co…
…ntinuation) (scikit-learn#9145)

* Merge neighbors.rst

* issue scikit-learn#4931

* Improve test implementation

* Update base.py

* Remove unused import

* Customize test for precomputed metric

* Change test function name

* rename _metrics to require_params, add set assert

Checking that the test is non-empty, and more didactic variable name

* Remove blank line

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

[MRG+2] algorithm='auto' should always work for nearest neighbors (co…
…ntinuation) (scikit-learn#9145)

* Merge neighbors.rst

* issue scikit-learn#4931

* Improve test implementation

* Update base.py

* Remove unused import

* Customize test for precomputed metric

* Change test function name

* rename _metrics to require_params, add set assert

Checking that the test is non-empty, and more didactic variable name

* Remove blank line

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

[MRG+2] algorithm='auto' should always work for nearest neighbors (co…
…ntinuation) (scikit-learn#9145)

* Merge neighbors.rst

* issue scikit-learn#4931

* Improve test implementation

* Update base.py

* Remove unused import

* Customize test for precomputed metric

* Change test function name

* rename _metrics to require_params, add set assert

Checking that the test is non-empty, and more didactic variable name

* Remove blank line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment