New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] makedirs(..., exists_ok) not available in Python 2 #9284

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
3 participants
@SebastinSanty
Contributor

SebastinSanty commented Jul 5, 2017

Reference Issue

Fixes #9279

What does this implement/fix? Explain your changes.

exists_ok parameter of os.makedirs() exists upwards of Python 3. This change will support Python 2 also.

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Jul 5, 2017

Member

LGTM. Now I'm not sure, though if this should be included in the #9240 refactoring of dataset fetching.

Member

jnothman commented Jul 5, 2017

LGTM. Now I'm not sure, though if this should be included in the #9240 refactoring of dataset fetching.

@jnothman jnothman changed the title from [MRG] makedirs(..., exists_ok) not available in Python 2 to [MRG+1] makedirs(..., exists_ok) not available in Python 2 Jul 5, 2017

@SebastinSanty

This comment has been minimized.

Show comment
Hide comment
@SebastinSanty

SebastinSanty Jul 6, 2017

Contributor

I guess #9240 can be rebased after this commit?

Contributor

SebastinSanty commented Jul 6, 2017

I guess #9240 can be rebased after this commit?

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Jul 6, 2017

Member
Member

jnothman commented Jul 6, 2017

@ogrisel ogrisel merged commit cf67fa4 into scikit-learn:master Jul 6, 2017

4 of 5 checks passed

codecov/patch 0% of diff hit (target 96.36%)
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 96.36% (-0.01%) compared to c2dfd75
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ogrisel

This comment has been minimized.

Show comment
Hide comment
@ogrisel

ogrisel Jul 6, 2017

Member

Let's rebase #9240 then :) Thanks for the fix.

Member

ogrisel commented Jul 6, 2017

Let's rebase #9240 then :) Thanks for the fix.

@SebastinSanty SebastinSanty deleted the SebastinSanty:exist_ok branch Jul 6, 2017

massich added a commit to massich/scikit-learn that referenced this pull request Jul 13, 2017

yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017

Merge tag '0.19b2' into releases
Release 0.19b2

* tag '0.19b2': (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (#9252)
  FIX t-SNE memory usage and many other optimizer issues (#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (#9332)
  Fix typos (#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (#9206)
  DOC Residual sum vs. regression sum (#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (#9317)
  More informative error message for classification metrics given regression output (#9275)
  [MRG] COSMIT Remove unused parameters in private functions (#9310)
  [MRG+1] Ridgecv normalize (#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (#7388)
  Add data_home parameter to fetch_kddcup99 (#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (#9284)
  ...

yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017

Merge branch 'releases' into dfsg (reremoved joblib and jquery)
* releases: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (#9252)
  FIX t-SNE memory usage and many other optimizer issues (#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (#9332)
  Fix typos (#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (#9206)
  DOC Residual sum vs. regression sum (#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (#9317)
  More informative error message for classification metrics given regression output (#9275)
  [MRG] COSMIT Remove unused parameters in private functions (#9310)
  [MRG+1] Ridgecv normalize (#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (#7388)
  Add data_home parameter to fetch_kddcup99 (#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (#9284)
  ...

yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017

Merge branch 'dfsg' into debian
* dfsg: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (#9252)
  FIX t-SNE memory usage and many other optimizer issues (#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (#9332)
  Fix typos (#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (#9206)
  DOC Residual sum vs. regression sum (#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (#9317)
  More informative error message for classification metrics given regression output (#9275)
  [MRG] COSMIT Remove unused parameters in private functions (#9310)
  [MRG+1] Ridgecv normalize (#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (#7388)
  Add data_home parameter to fetch_kddcup99 (#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (#9284)
  ...

dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

NelleV added a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017

paulha added a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017

AishwaryaRK added a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment