New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Ridgecv normalize #9302

Merged
merged 2 commits into from Jul 9, 2017

Conversation

Projects
None yet
2 participants
@agramfort
Member

agramfort commented Jul 8, 2017

Reference Issue

Fixes #9299

What does this implement/fix? Explain your changes.

normalize param was not passed to GridSearchCV in RidgeCV

@@ -1119,7 +1119,8 @@ def fit(self, X, y, sample_weight=None):
raise ValueError("cv!=None and store_cv_values=True "
" are incompatible")
parameters = {'alpha': self.alphas}
gs = GridSearchCV(Ridge(fit_intercept=self.fit_intercept),
gs = GridSearchCV(Ridge(fit_intercept=self.fit_intercept,
normalize=self.normalize),

This comment has been minimized.

@agramfort

agramfort Jul 8, 2017

Member

normalize was not passed here

@agramfort

agramfort Jul 8, 2017

Member

normalize was not passed here

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Jul 8, 2017

Member

LGTM

Member

jnothman commented Jul 8, 2017

LGTM

@jnothman jnothman changed the title from Ridgecv normalize to [MRG+1] Ridgecv normalize Jul 8, 2017

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Jul 8, 2017

Member

add a note to what's new?

Member

jnothman commented Jul 8, 2017

add a note to what's new?

@jnothman jnothman added this to the 0.19 milestone Jul 8, 2017

@agramfort

This comment has been minimized.

Show comment
Hide comment
@agramfort

agramfort Jul 9, 2017

Member

@jnothman i added already an entry to what's new

Member

agramfort commented Jul 9, 2017

@jnothman i added already an entry to what's new

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Jul 9, 2017

Member

Thanks. Don't know how I missed that

Member

jnothman commented Jul 9, 2017

Thanks. Don't know how I missed that

@jnothman jnothman merged commit a6753f3 into scikit-learn:master Jul 9, 2017

3 of 5 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

massich added a commit to massich/scikit-learn that referenced this pull request Jul 13, 2017

[MRG+1] Ridgecv normalize (#9302)
* FIX : normalize was not passed to grid search in RidgeCV

* update what's new

yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017

Merge tag '0.19b2' into releases
Release 0.19b2

* tag '0.19b2': (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (#9252)
  FIX t-SNE memory usage and many other optimizer issues (#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (#9332)
  Fix typos (#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (#9206)
  DOC Residual sum vs. regression sum (#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (#9317)
  More informative error message for classification metrics given regression output (#9275)
  [MRG] COSMIT Remove unused parameters in private functions (#9310)
  [MRG+1] Ridgecv normalize (#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (#7388)
  Add data_home parameter to fetch_kddcup99 (#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (#9284)
  ...

yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017

Merge branch 'releases' into dfsg (reremoved joblib and jquery)
* releases: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (#9252)
  FIX t-SNE memory usage and many other optimizer issues (#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (#9332)
  Fix typos (#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (#9206)
  DOC Residual sum vs. regression sum (#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (#9317)
  More informative error message for classification metrics given regression output (#9275)
  [MRG] COSMIT Remove unused parameters in private functions (#9310)
  [MRG+1] Ridgecv normalize (#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (#7388)
  Add data_home parameter to fetch_kddcup99 (#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (#9284)
  ...

yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017

Merge branch 'dfsg' into debian
* dfsg: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (#9252)
  FIX t-SNE memory usage and many other optimizer issues (#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (#9332)
  Fix typos (#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (#9206)
  DOC Residual sum vs. regression sum (#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (#9317)
  More informative error message for classification metrics given regression output (#9275)
  [MRG] COSMIT Remove unused parameters in private functions (#9310)
  [MRG+1] Ridgecv normalize (#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (#7388)
  Add data_home parameter to fetch_kddcup99 (#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (#9284)
  ...

dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

[MRG+1] Ridgecv normalize (#9302)
* FIX : normalize was not passed to grid search in RidgeCV

* update what's new

dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

[MRG+1] Ridgecv normalize (#9302)
* FIX : normalize was not passed to grid search in RidgeCV

* update what's new

NelleV added a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017

[MRG+1] Ridgecv normalize (#9302)
* FIX : normalize was not passed to grid search in RidgeCV

* update what's new

paulha added a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017

[MRG+1] Ridgecv normalize (#9302)
* FIX : normalize was not passed to grid search in RidgeCV

* update what's new

AishwaryaRK added a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017

[MRG+1] Ridgecv normalize (#9302)
* FIX : normalize was not passed to grid search in RidgeCV

* update what's new

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

[MRG+1] Ridgecv normalize (#9302)
* FIX : normalize was not passed to grid search in RidgeCV

* update what's new

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

[MRG+1] Ridgecv normalize (#9302)
* FIX : normalize was not passed to grid search in RidgeCV

* update what's new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment