Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG + 1] ENH add check_inverse in FunctionTransformer #9399
@jnothman I used the
Also, it seems that
Looks good apart from prints and possible use of resample.
Added some comments.
One further thing I was wondering whether the
random_state kwarg is worth adding. It's used by check_inverse, so if you for some reason need to control it, I agree you need this keyword, but it just feels a bit like adding 'noise' to the class for most cases.
@jnothman If we make it default it will not be back-compatible, isn't (we might need to deprecate the current behaviour). As a default it would make sense since the majority should have this behaviour.
It makes sense to me.
Not sure to know what you mean by "take a prefix of the data". If this is what I am thinking of, I am not sure that random sampling will make it more robust.
@@ Coverage Diff @@ ## master #9399 +/- ## ========================================== + Coverage 96.19% 96.19% +<.01% ========================================== Files 335 335 Lines 61800 61825 +25 ========================================== + Hits 59448 59473 +25 Misses 2352 2352