New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] FIX n_iter -> max_iter conversion in SGDClassifier #9558

Merged
merged 10 commits into from Aug 16, 2017

Conversation

Projects
None yet
3 participants
@amueller
Member

amueller commented Aug 15, 2017

Fixes #9549.

@jnothman jnothman changed the title from BUG n_iter -> max_iter conversion in SGDClassifier to [MRG+1] FIX n_iter -> max_iter conversion in SGDClassifier Aug 15, 2017

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Aug 15, 2017

Member

LGTM

Member

jnothman commented Aug 15, 2017

LGTM

@jnothman jnothman added the Blocker label Aug 15, 2017

@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Aug 16, 2017

Member

gonna fix doctests asap

Member

amueller commented Aug 16, 2017

gonna fix doctests asap

amueller added some commits Aug 16, 2017

@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Aug 16, 2017

Member

finally green

Member

amueller commented Aug 16, 2017

finally green

@NelleV

NelleV approved these changes Aug 16, 2017

@NelleV NelleV merged commit c7ca0c5 into scikit-learn:master Aug 16, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.17%)
Details
codecov/project 96.17% (+<.01%) compared to baa2048
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Aug 17, 2017

Member

Thanks :)

Member

amueller commented Aug 17, 2017

Thanks :)

paulha added a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017

[MRG+1] FIX n_iter -> max_iter conversion in SGDClassifier (#9558)
* move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation.

* move validate_params so we have self._max_iter in _fit

* validate params in init because the tests wants me to

* better check for input validation

* fix deprecation tests to call _validate_params

* fix parameter validation in PA classifier

* fix max_iter in doctests

* pep8 /doctest whitespace

* more doctests

* maybe I'll find them all....

@jnothman jnothman added this to the 0.19.1 milestone Aug 20, 2017

jnothman added a commit to jnothman/scikit-learn that referenced this pull request Aug 23, 2017

[MRG+1] FIX n_iter -> max_iter conversion in SGDClassifier (#9558)
* move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation.

* move validate_params so we have self._max_iter in _fit

* validate params in init because the tests wants me to

* better check for input validation

* fix deprecation tests to call _validate_params

* fix parameter validation in PA classifier

* fix max_iter in doctests

* pep8 /doctest whitespace

* more doctests

* maybe I'll find them all....

AishwaryaRK added a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017

[MRG+1] FIX n_iter -> max_iter conversion in SGDClassifier (#9558)
* move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation.

* move validate_params so we have self._max_iter in _fit

* validate params in init because the tests wants me to

* better check for input validation

* fix deprecation tests to call _validate_params

* fix parameter validation in PA classifier

* fix max_iter in doctests

* pep8 /doctest whitespace

* more doctests

* maybe I'll find them all....

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

[MRG+1] FIX n_iter -> max_iter conversion in SGDClassifier (#9558)
* move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation.

* move validate_params so we have self._max_iter in _fit

* validate params in init because the tests wants me to

* better check for input validation

* fix deprecation tests to call _validate_params

* fix parameter validation in PA classifier

* fix max_iter in doctests

* pep8 /doctest whitespace

* more doctests

* maybe I'll find them all....

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

[MRG+1] FIX n_iter -> max_iter conversion in SGDClassifier (#9558)
* move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation.

* move validate_params so we have self._max_iter in _fit

* validate params in init because the tests wants me to

* better check for input validation

* fix deprecation tests to call _validate_params

* fix parameter validation in PA classifier

* fix max_iter in doctests

* pep8 /doctest whitespace

* more doctests

* maybe I'll find them all....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment