New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+2] Implements ducktyping to allow for alternative Memory implementations #9584

Merged
merged 68 commits into from Aug 30, 2017
Commits
Jump to file or symbol
Failed to load files and symbols.
+1 −1
Diff settings

Always

Just for now

Viewing a subset of changes. View all

Import statements added

  • Loading branch information...
thechargedneutron committed Aug 22, 2017
commit 88ce9b0143e301c550cdfe5800de1c80bca30eb0
@@ -34,6 +34,7 @@
from sklearn.utils.fast_dict import IntFloatDict
from sklearn.utils.testing import assert_array_equal
from sklearn.utils.testing import assert_warns
from sklearn.utils.tests.test_validation import DummyMemory, WrongDummyMemory

This comment has been minimized.

@glemaitre

glemaitre Aug 22, 2017

Contributor

I would need @jnothman to tell me if doing this is fine.
I am not sure anymore that it is usually done in that way (even if we avoid code duplication)

This comment has been minimized.

@jnothman

jnothman Aug 22, 2017

Member

TBH, once we're using check_memory it's not that important to have a test in test_hierarchical.py. Yes, it's good to have some kind of integration testing, but I don't think we get much value out of it in this case. I'd happily see this PR without the changes to test_hierarchical and test_pipeline.

def test_deprecation_of_n_components_in_linkage_tree():
@@ -16,7 +16,6 @@
from sklearn.utils.testing import assert_warns
from sklearn.utils.testing import ignore_warnings
from sklearn.utils.testing import SkipTest
from sklearn.utils.tests.test_validation import DummyMemory, WrongDummyMemory
from sklearn.utils import as_float_array, check_array, check_symmetric
from sklearn.utils import check_X_y
from sklearn.utils.mocking import MockDataFrame
ProTip! Use n and p to navigate between commits in a pull request.