New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Resolve the problem with cross_val_predict(method=) when passing X or y as list #9600

Merged
merged 7 commits into from Aug 22, 2017

Conversation

Projects
None yet
3 participants
@CoderINusE
Contributor

CoderINusE commented Aug 22, 2017

Reference Issue

Fixes: #9592

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Aug 22, 2017

Member

Please make the title more descriptive, and the reference issue should be prefixed by "Fixes"

Member

jnothman commented Aug 22, 2017

Please make the title more descriptive, and the reference issue should be prefixed by "Fixes"

@CoderINusE CoderINusE changed the title from issue 9592 to Resolve the problem with cross_val_predict(method=) when passing X or y as list Aug 22, 2017

Rasul Kerimov added some commits Aug 22, 2017

Rasul Kerimov
Rasul Kerimov

CoderINusE and others added some commits Aug 22, 2017

Rasul Kerimov
@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Aug 22, 2017

Member

LGTM, thanks!

Member

jnothman commented Aug 22, 2017

LGTM, thanks!

@jnothman jnothman changed the title from Resolve the problem with cross_val_predict(method=) when passing X or y as list to [MRG+1] Resolve the problem with cross_val_predict(method=) when passing X or y as list Aug 22, 2017

@jnothman jnothman added this to the 0.19.1 milestone Aug 22, 2017

@jnothman jnothman added the Bug label Aug 22, 2017

@NelleV

This comment has been minimized.

Show comment
Hide comment
@NelleV

NelleV Aug 22, 2017

Member

Thanks @CoderINusE !

Member

NelleV commented Aug 22, 2017

Thanks @CoderINusE !

@NelleV NelleV merged commit 9e9b78d into scikit-learn:master Aug 22, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.16%)
Details
codecov/project 96.16% (+<.01%) compared to 6f42105
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python 2 new alerts
Details

jnothman added a commit to jnothman/scikit-learn that referenced this pull request Aug 23, 2017

[MRG+1] Resolve the problem with cross_val_predict(method=) when pass…
…ing X or y as list (#9600)

* issue 9592

* issue resolve

* resolve issue

* review

* Delete sample.py

* review

AishwaryaRK added a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017

[MRG+1] Resolve the problem with cross_val_predict(method=) when pass…
…ing X or y as list (#9600)

* issue 9592

* issue resolve

* resolve issue

* review

* Delete sample.py

* review

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

[MRG+1] Resolve the problem with cross_val_predict(method=) when pass…
…ing X or y as list (#9600)

* issue 9592

* issue resolve

* resolve issue

* review

* Delete sample.py

* review

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

Rasul Kerimov Jeremiah Johnson
[MRG+1] Resolve the problem with cross_val_predict(method=) when pass…
…ing X or y as list (#9600)

* issue 9592

* issue resolve

* resolve issue

* review

* Delete sample.py

* review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment