New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] add groups support to RFECV #9656

Merged
merged 9 commits into from Nov 17, 2017

Conversation

Projects
None yet
4 participants
@adamgreenhall
Contributor

adamgreenhall commented Aug 30, 2017

Reference Issue

related to #8127

What does this implement/fix? Explain your changes.

Adding support for cv groups (eg LeaveOneGroupOut) to RFECV.

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Aug 31, 2017

Member

Needs a test.

Member

jnothman commented Aug 31, 2017

Needs a test.

adamgreenhall added some commits Aug 31, 2017

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Sep 1, 2017

Member

otherwise LGTM

Member

jnothman commented Sep 1, 2017

otherwise LGTM

@jnothman jnothman changed the title from add groups to [MRG+1] add groups support to RFECV Sep 1, 2017

@glemaitre

couple of small changes

Show outdated Hide outdated sklearn/feature_selection/tests/test_rfe.py Outdated
Show outdated Hide outdated sklearn/feature_selection/tests/test_rfe.py Outdated
Show outdated Hide outdated sklearn/feature_selection/tests/test_rfe.py Outdated

@TomDLT TomDLT merged commit 48b82a6 into scikit-learn:master Nov 17, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.17%)
Details
codecov/project 96.17% (+<.01%) compared to 958a7cd
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python 1 new alert
Details
@TomDLT

This comment has been minimized.

Show comment
Hide comment
@TomDLT

TomDLT Nov 17, 2017

Member

Good job @adamgreenhall, thanks !

Member

TomDLT commented Nov 17, 2017

Good job @adamgreenhall, thanks !

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment