Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+2] Fix trustworthiness custom metric #9775


Fix almost equal error to be compatible with numpy 1.8.0

  • Loading branch information...
wdevazelhes committed Sep 18, 2017
commit 96d32212bce82a148d50c49b782910f5625ef149
@@ -327,7 +327,7 @@ def test_trustworthiness_unusual_metric():
assert_almost_equal(assert_warns(RuntimeWarning, trustworthiness, X, X,
0.6, decimal=1)
0.66, decimal=1)

This comment has been minimized.

Copy link

jnothman Sep 19, 2017


.66 appears drawn from thin air. Instead benchmark against the corresponding precomputed distances

def test_early_exaggeration_too_small():
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.