New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Improve example plot_label_propagation_structure.py #9788

Merged
merged 1 commit into from Sep 19, 2017

Conversation

Projects
None yet
4 participants
@qinhanmin2014
Member

qinhanmin2014 commented Sep 18, 2017

Reference Issue

What does this implement/fix? Explain your changes.

The example looks good in 0.18 (except for the title)
sphx_glr_plot_label_propagation_structure_001
But looks strange in 0.19
sphx_glr_plot_label_propagation_structure_001
new version from Circle CI:
sphx_glr_plot_label_propagation_structure_001

Any other comments?

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Sep 18, 2017

Member

Thanks, makes sense. LGTM. But to double-check, please review @musically-ut?

Member

jnothman commented Sep 18, 2017

Thanks, makes sense. LGTM. But to double-check, please review @musically-ut?

@jnothman jnothman changed the title from [MRG] Improve example plot_label_propagation_structure.py to [MRG+1] Improve example plot_label_propagation_structure.py Sep 18, 2017

@jnothman jnothman added this to the 0.19.1 milestone Sep 18, 2017

@musically-ut

This comment has been minimized.

Show comment
Hide comment
@musically-ut

musically-ut Sep 19, 2017

Contributor

LGTM, too. I wonder if there are any other examples which are effected by the alpha to 1 - alpha change.

Contributor

musically-ut commented Sep 19, 2017

LGTM, too. I wonder if there are any other examples which are effected by the alpha to 1 - alpha change.

@qinhanmin2014

This comment has been minimized.

Show comment
Hide comment
@qinhanmin2014

qinhanmin2014 Sep 19, 2017

Member

At a glance, other semi supervised examples seems to be fine (though the result may be different bacause of the bug fix in 0.19).

Member

qinhanmin2014 commented Sep 19, 2017

At a glance, other semi supervised examples seems to be fine (though the result may be different bacause of the bug fix in 0.19).

@lesteve

This comment has been minimized.

Show comment
Hide comment
@lesteve

lesteve Sep 19, 2017

Member

Good catch @qinhanmin2014, LGTM, merging!

Member

lesteve commented Sep 19, 2017

Good catch @qinhanmin2014, LGTM, merging!

@lesteve lesteve merged commit e443c05 into scikit-learn:master Sep 19, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 08b524d...dd0ef77
Details
codecov/project 96.17% remains the same compared to 08b524d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@qinhanmin2014 qinhanmin2014 deleted the qinhanmin2014:my-feature-3 branch Sep 19, 2017

jnothman added a commit to jnothman/scikit-learn that referenced this pull request Oct 3, 2017

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment