Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
[WIP] Sphinx based documentation #431
Conversation
|
If you feel like contributing: the number one place help is needed is adding doc strings to the modules e.g. |
codecov-io
commented
Jul 11, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 86.46% 86.49% +0.03%
==========================================
Files 22 22
Lines 1581 1585 +4
==========================================
+ Hits 1367 1371 +4
Misses 214 214
Continue to review full report at Codecov.
|
|
Thanks for starting this. How do I view the rendered documentation? (https://707-54340642-gh.circle-artifacts.com/0/home/ubuntu/doc/skopt/notebooks/bayesian-optimization.html) corresponds to the original version? |
|
At the moment by Figuring out how to make CircleCI build it is on the list of things to do |
|
Hmm, I think it might work if you add the same lines to |
|
PRs to this PR welcome. I think this is the only way to overcome the problem of not merging this before it is complete and the fact that by myself I will never finish this. |
|
I think we should try and convert our formatting to https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt mostly because there is a sphinx extension that can render this nicely and because it doesn't look horrible as plain text docstring. Open to other ideas. For methods/functions/classes that are "simple" we can keep a plain doc string, but if we want to document parameters and return values we should adopt the numpy style. |
|
Alternative format that works well is the scikit-learn one. |
|
@iaroslav-ai what do you think about trimming the |
|
@betatim would be really great if you would try to shrink it a bit, it is quite big indeed! |
|
New snapshot: https://721-54340642-gh.circle-artifacts.com/0/tmp/circle-artifacts.kdXLWjd/index.html (when did we add this much stuff to skopt? Always thought this was a cute little library ... |
betatim
referenced
this pull request
Jul 14, 2017
Merged
Rename searchcv, cross reference hyperparameter optimization notebooks #436
|
Thanks for your work! What thoughts do you have on integrating the example notebooks? |
|
Having Can you see a way to use notebooks with gallery? |
|
nbsphinx seems pretty neat. Why not just use it? |
Wanted to hear some opinions :) I think it isn't as widely used as sphinx-gallery so if there was a way to use gallery that would be better but seems there isn't. Will probably work on this tomorrow a bit. Slow progress. |
|
hm my circle CI browser plugin fails to pick up on the build. I guess because the last one failed? Not sure :-/ |
betatim
added some commits
Jul 11, 2017
|
Forgot to add the Is there a tool (that works well) for converting our docstrings to numpydoc format? It isn't hard but pretty tedious (aka error prone) and feels like it is impossible to keep up with changes made elsewhere :) In general what do people think about the layout/sections? Was thinking to add a few of the example notebooks as narrative docs after "quick start" (the what is bayes opt one and the BayesSearchCV one). Link to the rest as examples. |
betatim commentedJul 11, 2017
•
edited
Fixes #428
Getting started with a documentation marathon.