Transition of DARPA SD2 Implementation of PersistenceImages() into persim module #45
Conversation
…tation inside the class, moved transform() method to _transform() and madea new transform() method which ingests one or more persistence diagrams
…unction, updated usage comments in PersistenceImages(), wrote uniform kernel function, updated tutorials in jupyter notebook
…hed several bugs included warnings related to using np.copy() in PersistenveImager().fit_transform(), added uniform() to images.py for use as a kernel function, added example of updating weight function to Persistence Images.ipynb
…ed Classificaiton with persistence images notebook to use new PersistenceImages() class, added paralellization example to Persistence Image notebook, made all unit tests use numpt.testing assert methods
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 80.90% 74.76% -6.14%
==========================================
Files 10 12 +2
Lines 550 868 +318
Branches 114 160 +46
==========================================
+ Hits 445 649 +204
- Misses 77 177 +100
- Partials 28 42 +14
Continue to review full report at Codecov.
|
|
This is great! Thank you 💯 I gave the code a very brief skim and added a few comments. @ctralie do you have bandwidth to give a more thorough review of the implementation details? |
|
Yes, I will try to review by the end of this week
…On Thu, Dec 17, 2020 at 2:34 PM Nathaniel Saul ***@***.***> wrote:
This is great! Thank you 💯
I gave the code a very brief skim and added a few comments. @ctralie
<https://github.com/ctralie> do you have bandwidth to give a more
thorough review of the implementation details?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJWDZRSCYCDX45DIP7APSDSVJMK5ANCNFSM4VAB4OSA>
.
|
- Modified PersistenceImager().__repr__ to create a valid constructor. - Removed PersistenceImager().dict_print and replaced with prettyprint. - Changed default kernel function name from bvncdf to gaussian to make more understandable. - Added a new test to ensure guassian parameter sigma can be either a numpy array or a list of lists. - Renamed some kernel functions by removing leading underscore to ensure proper loading. - Updated block comments in PersistenceImager() to reflect updated __repr__ method.
|
This looks great by the way! 💯 The final thing is adding some bits to the documentation. |
…ith from persim import <module>
|
@francismotta For the docs, you'll have to add an entry here and make sure that everything renders correctly. It should be pretty straight forward to build. If I remember correctly, just running a |
…eights.py - Made plot methods in PersistenceImager return Axes object - Deprecated PersImage class using deprecation sphinx decorator
|
@sauln Documentation updated and renders nicely! I also deprecated PersImage. By the way, There seems to be something wrong with this notebook (in my fork and the published version). I am unable to open it: |
…anged from 0.1.4 to 0.1.5
… valid string, updated documentation, added parameter validation method and unittests
|
I was able to fix the problems with the |
…x autodoc warning related to use of |V(G)|x|V(G)|
…ted class methods and attributes, changed member order to groupwise from its default alphabetical to ensure class methods appear grouped together in the documentation html ahead of attributes which alspo appear grouped together, added docstrings for public attributes of PersistenceImager
This fork contains a large update to the persistence images module through the implementation of the PersistenceImages() class, which developed as part of the DARPA Synergistic Discovery and Design program. New functionality includes: