Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat auto start #59

Merged
merged 16 commits into from
Jan 24, 2019
Merged

Feat auto start #59

merged 16 commits into from
Jan 24, 2019

Conversation

azuldev1
Copy link
Contributor

Issue: #56 tested on Mac, Windows, and Ubuntu. Used node startup package. Had an issue using Linux AppImage, the workaround mentioned here placed the AppImage in the correct "~./config/autostart" but didn't start Stele. Added .zip build which works correctly with the node-auto-launch package.

Copy link
Member

@tnordberg tnordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled down and tested on my Mac. The auto-start setting worked as intended, and the new setting is nicely positioned in the current form.
I'm requesting a single cleanup item before approving.

src/autoLaunch.js Outdated Show resolved Hide resolved
console.log("autolaunch enabled");
kioskAutoLaunch.enable()
console.log(app.getName());
function whichSetting(settingsBool, configSetting) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated logging

@azuldev1 azuldev1 merged commit e80880b into master Jan 24, 2019
@bryankennedy bryankennedy deleted the feat-auto-start branch November 19, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants