/SwiftSoup

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Accessibility Changes #78

Merged
merged 2 commits into from Jul 17, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@danramteke @scinfu
@danramteke

danramteke commented May 10, 2018

  1. The Pattern helper is useful, however, it's matcher method isn't public
  2. When trying to reference types inside of the SwiftSoup module that have the same names as a type outside the module, the swift compiler emits an ambiguous reference error. For example Pattern has an ambiguous reference. And trying to say SwiftSoup.Pattern, the compiler says the SwiftSoup class doesn't have a member Pattern. Removing the class SwiftSoup helps the compiler know that SwiftSoup refers to the module and only the module, and not the class.

Daniel added some commits May 7, 2018

Daniel
make Matcher method public on Pattern
e0f7c15
Daniel
Fix namespacing. Otherwise trying to explicity refer to members of th… 
…e module will look at the class 'SwiftSoup', and error out
Loading status checks…
47c40c1

@scinfu scinfu merged commit 01ef3d5 into scinfu:master Jul 17, 2018
2 checks passed

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment