Two Accessibility Changes #78
Merged
Conversation
2 commits
May 7, 2018
added …e module will look at the class 'SwiftSoup', and error out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Pattern
helper is useful, however, it's matcher method isn'tpublic
SwiftSoup
module that have the same names as a type outside the module, the swift compiler emits an ambiguous reference error. For examplePattern
has an ambiguous reference. And trying to saySwiftSoup.Pattern
, the compiler says the SwiftSoup class doesn't have a memberPattern
. Removing the classSwiftSoup
helps the compiler know thatSwiftSoup
refers to the module and only the module, and not the class.