Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Accessibility Changes #78

Merged
merged 2 commits into from Jul 17, 2018
Merged

Two Accessibility Changes #78

merged 2 commits into from Jul 17, 2018

Conversation

danramteke
Copy link

  1. The Pattern helper is useful, however, it's matcher method isn't public
  2. When trying to reference types inside of the SwiftSoup module that have the same names as a type outside the module, the swift compiler emits an ambiguous reference error. For example Pattern has an ambiguous reference. And trying to say SwiftSoup.Pattern, the compiler says the SwiftSoup class doesn't have a member Pattern. Removing the class SwiftSoup helps the compiler know that SwiftSoup refers to the module and only the module, and not the class.

@scinfu scinfu merged commit 01ef3d5 into scinfu:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants