Upgrade to Go 1.13 #3362
Upgrade to Go 1.13 #3362
Conversation
lukedirtwalker
force-pushed
the
pubGo1_13
branch
from
fbef8a0
to
0f85368
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @karampok)
There was a problem hiding this comment.
Reviewable status:
WORKSPACE, line 364 at r1 (raw file):
importpath = "github.com/smartystreets/goconvey", vcs = "git", remote = "https://github.com/kormat/goconvey.git",
I would like not to be in a personal space a dependency, but I suppose it is okay since we want to remove convey
(I was a bit surprised that our change was only the SoMsg :) )
There was a problem hiding this comment.
Reviewable status:
WORKSPACE, line 364 at r1 (raw file):
Previously, karampok (Konstantinos) wrote…
I would like not to be in a personal space a dependency, but I suppose it is okay since we want to remove convey
(I was a bit surprised that our change was only the SoMsg :) )
Yeah agreed. Also this has been here since a long time.
This is also requires an upgrade of GoConvey Fixes scionproto#3349 Fixes scionproto#3009
lukedirtwalker
force-pushed
the
pubGo1_13
branch
from
0f85368
to
59d647a
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
Recently we saw SIG acceptance tests fail more often that usual. Since the Go1.13 change (scionproto#3362) we saw in some SIGs problems with the TUN device. Investigating further we came across golang/go#30624. From there we saw that water library is very old and still uses os.OpenFile, which was replaced in other similar libs to mitigate afformentioned Go issue.
Recently we saw SIG acceptance tests fail more often that usual. Since the Go1.13 change (#3362) we saw in some SIGs problems with the TUN device. Investigating further we came across golang/go#30624. From there we saw that water library is very old and still uses os.OpenFile, which was replaced in other similar libs to mitigate afformentioned Go issue.
This also upgrades the GoConvey dependency as it is required for Go 1.13.
Fixes #3349
Fixes #3009
This change is