rust: bump protobuf to 3.2.0#126
Merged
varungandhi-src merged 1 commit intoMar 6, 2023
Merged
Conversation
varungandhi-src
approved these changes
Mar 6, 2023
Contributor
|
Apologies for missing this earlier. Feel free to @ of the maintainers directly in the future if your PR hasn't been reviewed/approved within a few days. |
Contributor
Author
No worries! I appreciate you landing this.
Gotcha, can do! Wasn't sure of the etiquette! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This branch updates protobuf to 3.2.0, which the latest version of the [
protobuf]https://github.com/stepancheg/rust-protobuf/) crate.Normally, I wouldn't open a PR to bump a dependency like this, but I'm in the process of updating a vendored rust-analyzer in a monorepo, and I can't have both protobuf-3.2.0 and protobuf-3.1.0 together without some patching that I'd strongly prefer to avoid. This was the approach of least resistance.
Test plan
Ran
./dev/proto-generate.sh; it appeared to have succeeded (and partially reformatteddocs/scip.mdfile).