Make ranges typed oneofs#387
Merged
Merged
Conversation
Introduce SingleLineRange and MultiLineRange message types, and add typed_range and typed_enclosing_range oneof fields to Occurrence. The old repeated int32 range and enclosing_range fields are marked deprecated. The typed fields are self-documenting and eliminate the need to disambiguate 3-element vs 4-element arrays at runtime.
JamyDev
approved these changes
Jun 4, 2026
- Add Range.Validate; reject malformed enclosing ranges in convert - Guard readTypedRange against nil oneof message pointers - Surface missing/malformed occurrence ranges in scip lint - Sort FindOccurrences by range only (no symbol tiebreaker)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure the storage savings are worth the effort.