Subtract sample run by empty can #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got a new vanadium simulation that doesn't result in negative counts. I am going to switch to that after #145 is merged to avoid conflicts. |
jl-wynen
force-pushed
the
subtract-empty-can
branch
from
9e79e0a to
cdf78d5
Compare
|
This is now based on #160 and needs to wait until that is merged. |
jl-wynen
force-pushed
the
subtract-empty-can
branch
from
cdf78d5 to
e144fad
Compare
|
Rebased onto main |
Comment on lines
+341
to
+345
| def subtract_background( | ||
| data: FocussedDataDspacing[SampleRun], | ||
| background: FocussedDataDspacing[BackgroundRun], | ||
| ) -> BackgroundSubtractedData[SampleRun]: | ||
| return BackgroundSubtractedData[SampleRun](data.bins.concatenate(-background)) |
There was a problem hiding this comment.
Will we need the background subtraction to work also for histogrammed data?
There was a problem hiding this comment.
I don't know. For now, I have not seen histogrammed data at this point in the workflow.
jl-wynen
commented
May 19, 2025
| return get_path(f"DREAM_simple_pwd_workflow/{prefix}data_dream_vanadium.csv.zip") | ||
| return get_path( | ||
| f"DREAM_simple_pwd_workflow/{prefix}data_dream_vanadium_inc_coh.csv.zip" | ||
| ) |
There was a problem hiding this comment.
This used to incorrectly use the file without coherent scattering.
jl-wynen
commented
May 19, 2025
| "workflow = powder.with_pixel_mask_filenames(workflow, [])\n", | ||
| "\n", | ||
| "# Enable subtraction by an empty can measurement:\n", | ||
| "powder.correction.add_empty_can_subtraction(workflow)" |
There was a problem hiding this comment.
I don't like this mechanism. I think a dedicated class for powder workflows would help here.
SimonHeybrock
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141
This results in a lot of negative counts. Checking with IDS...
This still needs a way to disable background subtraction.