From a29285b2ed34f7cc6bd17b5bbe3031a5b0709dc8 Mon Sep 17 00:00:00 2001
From: Neil Vaytet <neil.vaytet@ess.eu>
Date: Fri, 4 Jul 2025 15:21:37 +0200
Subject: [PATCH 1/2] add kwargs to workflows in case we want to use things
 like on-the-fly tof lookup table generation

---
 src/ess/dream/workflows.py | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/src/ess/dream/workflows.py b/src/ess/dream/workflows.py
index 52a0febd..d83957c8 100644
--- a/src/ess/dream/workflows.py
+++ b/src/ess/dream/workflows.py
@@ -95,7 +95,7 @@ def _collect_reducer_software() -> ReducerSoftware:
     )
 
 
-def DreamWorkflow() -> sciline.Pipeline:
+def DreamWorkflow(**kwargs) -> sciline.Pipeline:
     """
     Dream generic workflow with default parameters.
     The workflow is based on the GenericTofWorkflow.
@@ -104,10 +104,16 @@ def DreamWorkflow() -> sciline.Pipeline:
 
     It can be used as is, or as a base for more specific workflows, such as
     ``DreamPowderWorkflow``.
+
+    Parameters
+    ----------
+    kwargs:
+        Additional keyword arguments are forwarded to the base ``GenericTofWorkflow``.
     """
     wf = GenericTofWorkflow(
         run_types=[SampleRun, VanadiumRun, EmptyCanRun],
         monitor_types=[BunkerMonitor, CaveMonitor],
+        **kwargs,
     )
     wf[DetectorBankSizes] = DETECTOR_BANK_SIZES
     wf[NeXusName[BunkerMonitor]] = "monitor_bunker"
@@ -137,7 +143,7 @@ def default_parameters() -> dict:
     }
 
 
-def DreamPowderWorkflow(*, run_norm: RunNormalization) -> sciline.Pipeline:
+def DreamPowderWorkflow(*, run_norm: RunNormalization, **kwargs) -> sciline.Pipeline:
     """
     Dream powder workflow with default parameters.
 
@@ -145,13 +151,15 @@ def DreamPowderWorkflow(*, run_norm: RunNormalization) -> sciline.Pipeline:
     ----------
     run_norm:
         Select how to normalize each run (sample, vanadium, etc.).
+    kwargs:
+        Additional keyword arguments are forwarded to the base ``DreamWorkflow``.
 
     Returns
     -------
     :
         A workflow object for DREAM.
     """
-    wf = DreamWorkflow()
+    wf = DreamWorkflow(**kwargs)
     for provider in itertools.chain(powder_providers, _cif_providers):
         wf.insert(provider)
     insert_run_normalization(wf, run_norm)
@@ -161,7 +169,7 @@ def DreamPowderWorkflow(*, run_norm: RunNormalization) -> sciline.Pipeline:
     return wf
 
 
-def DreamGeant4Workflow(*, run_norm: RunNormalization) -> sciline.Pipeline:
+def DreamGeant4Workflow(*, run_norm: RunNormalization, **kwargs) -> sciline.Pipeline:
     """
     Workflow with default parameters for the Dream Geant4 simulation.
 
@@ -169,13 +177,15 @@ def DreamGeant4Workflow(*, run_norm: RunNormalization) -> sciline.Pipeline:
     ----------
     run_norm:
         Select how to normalize each run (sample, vanadium, etc.).
+    kwargs:
+        Additional keyword arguments are forwarded to the base ``DreamWorkflow``.
 
     Returns
     -------
     :
         A workflow object for DREAM.
     """
-    wf = DreamWorkflow()
+    wf = DreamWorkflow(**kwargs)
     for provider in itertools.chain(geant4_providers, powder_providers, _cif_providers):
         wf.insert(provider)
     insert_run_normalization(wf, run_norm)

From fc13e805d435ebb29ba13ade98ef09008a43d7aa Mon Sep 17 00:00:00 2001
From: Neil Vaytet <neil.vaytet@ess.eu>
Date: Fri, 4 Jul 2025 21:04:54 +0200
Subject: [PATCH 2/2] make func links in docstring

---
 src/ess/dream/workflows.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/ess/dream/workflows.py b/src/ess/dream/workflows.py
index d83957c8..322d9a57 100644
--- a/src/ess/dream/workflows.py
+++ b/src/ess/dream/workflows.py
@@ -108,7 +108,8 @@ def DreamWorkflow(**kwargs) -> sciline.Pipeline:
     Parameters
     ----------
     kwargs:
-        Additional keyword arguments are forwarded to the base ``GenericTofWorkflow``.
+        Additional keyword arguments are forwarded to the base
+        :func:`GenericTofWorkflow`.
     """
     wf = GenericTofWorkflow(
         run_types=[SampleRun, VanadiumRun, EmptyCanRun],
@@ -152,7 +153,7 @@ def DreamPowderWorkflow(*, run_norm: RunNormalization, **kwargs) -> sciline.Pipe
     run_norm:
         Select how to normalize each run (sample, vanadium, etc.).
     kwargs:
-        Additional keyword arguments are forwarded to the base ``DreamWorkflow``.
+        Additional keyword arguments are forwarded to the base :func:`DreamWorkflow`.
 
     Returns
     -------
@@ -178,7 +179,7 @@ def DreamGeant4Workflow(*, run_norm: RunNormalization, **kwargs) -> sciline.Pipe
     run_norm:
         Select how to normalize each run (sample, vanadium, etc.).
     kwargs:
-        Additional keyword arguments are forwarded to the base ``DreamWorkflow``.
+        Additional keyword arguments are forwarded to the base :func:`DreamWorkflow`.
 
     Returns
     -------