-
Notifications
You must be signed in to change notification settings - Fork 2
Add lower pins #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lower pins #189
Conversation
| 'sphinxcontrib.autodoc_pydantic', | ||
| 'sphinxcontrib.bibtex', | ||
| 'nbsphinx', | ||
| 'myst_parser', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change came from the copier update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so. Did you resolve a conflict for this? It looks like the quotes were changed in ESSdiffraction at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there was a conflict, I resolved it by changing the quotes to be like in copier_template and keep sphinxcobtrib.bibtex that was not in the list from copier_template
|
Now the lower-pin tests pass: https://github.com/scipp/essdiffraction/actions/runs/16293424662/job/46008694444 |
1155aac to
1c7fd61
Compare
pyproject.toml
Outdated
| # Make sure to list one dependency per line. | ||
| dependencies = [ | ||
| "dask", | ||
| "dask>=2024.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@jokasimr could you retrigger this copier update here? |
Did you mean that I should call |
This needs to wait for #190 |
Tests the changes in scipp/copier_template#261