Update to use the new tof lookup table workflow #190
Conversation
There was a problem hiding this comment.
The changes look good. Can you update the lower pin?
Also, did you check whether https://github.com/scipp/essdiffraction/blob/main/tools/dream-make-tof-lookup-table.ipynb still works?
No, and that is an issue I was wondering about... how do we ensure these notebooks don't get out of date? Edit: I now moved the notebook inside the docs, and use a smaller number of neutrons. |
| " choppers=disk_choppers, neutrons=5_000_000, source_position=sc.vector([0, 0, 0], unit='m'),\n", | ||
| ")\n", | ||
| "\n", | ||
| "wf[time_of_flight.NumberOfSimulatedNeutrons] = 200_000 # Increase this number for more reliable results\n", |
There was a problem hiding this comment.
Can you add to the docs (here or in data.py) the number used for the table? Or is it encoded in the hdf5 file?
There was a problem hiding this comment.
It isn't. We should probably make it a coordinate, like the other metadata?
There was a problem hiding this comment.
Yes, but it should be unaligned.
There was a problem hiding this comment.
Hmm that said, it's something specific to Tof. It's actually the neutrons that were in the source, not the neutrons that make it to the detectors.
If the simulation is done with mcstas, with parameter should not be there.
The other parameters (distamce and time resolution, etc.) belong with the table.
There was a problem hiding this comment.
True. But it can still be good to encode this kind of metadata in the file. But that is a longer discussion as we know...
For now, just add it to the docs so we can reproduce it later.
This is a necessary update after scipp/essreduce#253
Only the tests were updated, as the main mode of operation is to use a lookup table read from a file.