Add more message adapter tests #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
reviewed
Apr 7, 2025
|
|
||
| assert len(self.fake_logger.exception_calls) == 1 | ||
| assert ( | ||
| "error adapting message" in self.fake_logger.exception_calls[0][0].lower() |
Member
There was a problem hiding this comment.
Suggested change
| "error adapting message" in self.fake_logger.exception_calls[0][0].lower() | |
| "error adapting message" in self.fake_logger.exception_calls[-1][0].lower() |
Should we rather use [-1] index because it should be the latest one?
Also it won't break even if we insert more log related tests above.
Member
There was a problem hiding this comment.
Ah sorry now I understood. The fake logger is set up before every method. Feel free to ignore this suggestion.
YooSunYoung
approved these changes
Apr 7, 2025
SimonHeybrock
merged commit 849d246
into
isolate-from-upstream-topic-source-name
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix some small bugs in Kafka adapters, which ignored the
stream_lut.