From a8ed92012612507ca73bd0fa2552f715fb28e845 Mon Sep 17 00:00:00 2001 From: Johannes Kasimir Date: Tue, 26 Aug 2025 11:19:48 +0200 Subject: [PATCH 1/2] fix: supermirror params --- src/ess/estia/workflow.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ess/estia/workflow.py b/src/ess/estia/workflow.py index 84001d1c..f7efbf22 100644 --- a/src/ess/estia/workflow.py +++ b/src/ess/estia/workflow.py @@ -44,7 +44,8 @@ def mcstas_default_parameters() -> dict: return { supermirror.MValue: sc.scalar(5, unit=sc.units.dimensionless), - supermirror.CriticalEdge: 0.022 * sc.Unit("1/angstrom"), + # The reference sample in the McStas simulation has R=1 everywhere + supermirror.CriticalEdge: sc.scalar(float('inf'), unit='angstrom'), supermirror.Alpha: sc.scalar(0.25 / 0.088, unit=sc.units.angstrom), DetectorSpatialResolution[RunType]: 0.0025 * sc.units.m, NeXusDetectorName: "detector", From 09ed24906435e3fc87054aeb93a6b57540fa073d Mon Sep 17 00:00:00 2001 From: Johannes Kasimir Date: Tue, 26 Aug 2025 11:49:32 +0200 Subject: [PATCH 2/2] fix --- src/ess/estia/workflow.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ess/estia/workflow.py b/src/ess/estia/workflow.py index f7efbf22..efe09daf 100644 --- a/src/ess/estia/workflow.py +++ b/src/ess/estia/workflow.py @@ -45,7 +45,7 @@ def mcstas_default_parameters() -> dict: return { supermirror.MValue: sc.scalar(5, unit=sc.units.dimensionless), # The reference sample in the McStas simulation has R=1 everywhere - supermirror.CriticalEdge: sc.scalar(float('inf'), unit='angstrom'), + supermirror.CriticalEdge: sc.scalar(float('inf'), unit='1/angstrom'), supermirror.Alpha: sc.scalar(0.25 / 0.088, unit=sc.units.angstrom), DetectorSpatialResolution[RunType]: 0.0025 * sc.units.m, NeXusDetectorName: "detector",