WIP: proton charge correction #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
Some questions remain, mainly about correctness and if this structure is really practical.
It would be nice to be able to compute the corrections (statically) and apply them all in one provider.
But that's not possible because they have different shapes.
The proton charge correction is a function of the pulse time and the other corrections are functions of detector pixels and/or wavelength.
Another option is to just store
event_time_zeroon the events and lookup the proton charge for each event instead of for each pulse. It's less efficient, but probably not so inefficient that it becomes relevant.