Clean up function bindings #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/reference/free-functions.rst
Outdated
| @@ -59,6 +60,7 @@ Math | |||
| round | |||
| sqrt | |||
| subtract | |||
| unary_minus | |||
There was a problem hiding this comment.
Numpy calls this differently? https://numpy.org/doc/stable/reference/generated/numpy.negative.html
There was a problem hiding this comment.
That's why I didn't find it! Renaming...
src/scipp/core/logical.py
Outdated
Comment on lines
12
to
27
| """Element-wise logical negation. | ||
|
|
||
| Equivalent to | ||
|
|
||
| .. code-block:: python | ||
|
|
||
| ~a | ||
|
|
||
| :param x: Input data. | ||
| :return: The logical inverse of `x`. | ||
| """ |
There was a problem hiding this comment.
Remember that we can use a new docstring style! But we may also want to leave this here and try to auto-convert all of them at once.
There was a problem hiding this comment.
Ah right, this was largely copy-pasted. I am going to change it, there is no reason to merge it like this.
There was a problem hiding this comment.
Done. I tried pyment but it struggles with type hints like Union, example sections, and see also sections. I ended up doing it with a few search and replace operations...
jl-wynen
force-pushed
the
fix-operator-binding
branch
from
3ce9e3a
to
fe34449
Compare
SimonHeybrock
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of issues with the bindings and adds more tests. I think we have coverage of all exposed functions now.
Also removes some unused bindings.