Support __bool__ where sensible
#2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Jul 12, 2022
| if (self.unit() != scipp::units::none) | ||
| throw scipp::except::UnitError( | ||
| "The thruth value of a variable with unit is undefined."); | ||
| return self.template value<bool>() == true; |
There was a problem hiding this comment.
Is this the part that makes sure we don't have more than one value in the self? self.value raises if the variable is not 0-D?
|
|
||
|
|
||
| def test_scalar_Variable_conversion_to_builtin_bool_bad_dtype(): | ||
| var = sc.scalar(value=1.0, unit=None) |
There was a problem hiding this comment.
Out of interest, do we support conversion from integer? e.g. sc.scalar(value=1, unit=None)
There was a problem hiding this comment.
No, because we use .value<bool>().
Co-authored-by: Neil Vaytet <39047984+nvaytet@users.noreply.github.com>
nvaytet
approved these changes
Jul 12, 2022
jl-wynen
requested changes
Jul 12, 2022
| if (self.unit() != scipp::units::none) | ||
| throw scipp::except::UnitError( | ||
| "The thruth value of a variable with unit is undefined."); | ||
| return self.template value<bool>() == true; |
There was a problem hiding this comment.
bool cannot have variances.
jl-wynen
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2691.