MAINT: use pathlib for path manipulation #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MridulS
changed the title
jl-wynen
requested changes
Apr 24, 2024
src/scippnexus/base.py
Outdated
| return self.file[sel[1:]] | ||
| elif sel.endswith('/'): | ||
| return self[sel[:-1]] | ||
| sel_path = Path(sel) |
There was a problem hiding this comment.
This depends on the OS. You need to use PosixPath here. Or better AbstractPosixPath because it doesn't refer to a real file.
This is one reason why only testing on Linux is not enough... But that is a different discussion.
|
There are unrelated windows error in scippnexus btw. |
MridulS
force-pushed
the
pathlib_santize
branch
from
6dcc725
to
9c27556
Compare
jl-wynen
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #208 but I feel like there should be a better solution.