Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename invnorm to invgauss (Trac #1172) #1699

Closed
scipy-gitbot opened this issue Apr 25, 2013 · 3 comments
Closed

rename invnorm to invgauss (Trac #1172) #1699

scipy-gitbot opened this issue Apr 25, 2013 · 3 comments
Labels
Milestone

Comments

@scipy-gitbot
Copy link

Original ticket http://projects.scipy.org/scipy/ticket/1172 on 2010-05-10 by @josef-pkt, assigned to unknown.

reported by Matthew Brett

invnorm is a confusing name for the distribution, in the literature it is mostly called the Inverse Gaussian, or for some parameterization Wald, np.random uses Wald

see thread at http://mail.scipy.org/pipermail/scipy-user/2010-April/025003.html

proposal:
depreciate name invnorm and replace it with invgauss

How can we depreciate a class and a class instance?

Docstring can have a warning text, but I don't see where we can raise a warning.

@scipy-gitbot
Copy link
Author

@rgommers wrote on 2010-11-13

For 0.8.0 we had a discussion about deprecating a class, and settled on decorating the __init__ method with @deprecate. If an instance is created in the code, that's more of a problem maybe. You don't want to issue a warning on import of the module, only when the instance is used, right? One can decorate all implemented methods (_rvs, _pdf, _cdf, _stats) but that still doesn't cover it all. But that plus adding it to the docstring is perhaps the best you can do.

@scipy-gitbot
Copy link
Author

@rgommers wrote on 2010-11-28

Added invgauss and deprecated invnorm in rgommers@4776ec7

@scipy-gitbot
Copy link
Author

@rgommers wrote on 2010-11-28

Committed in 505ee61.

patvarilly pushed a commit to patvarilly/scipy that referenced this issue May 1, 2013
patvarilly pushed a commit to patvarilly/scipy that referenced this issue May 1, 2013
BUG: special: fix accuracy issues in complex erf by using a different implementation

This PR changes complex-valued erf family functions to use implementations from
Steven G. Johnson's Faddeeva package. This is more numerically stable than the
previously used implementation.

Closes Trac scipy#1207, scipy#1699, scipy#1757, scipy#1758, scipy#1759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant