Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_MINPACK_LOCK not held when calling into minpack from least_squares #8700

Closed
batterseapower opened this issue Apr 9, 2018 · 2 comments
Closed
Milestone

Comments

@batterseapower
Copy link
Contributor

Minpack is not thread safe currently. This was reported as bug #3500, which was fixed by #7999, protecting all minpack calls with a lock. Unfortunately that PR only patched minpack.py, the two uses in least_squares.py were missed.

I tried to put together a PR to fix this but importing _MINPACK_LOCK into least_squares.py creates an import loop so it wasn't very tidy & and I gave up.

Scipy/Numpy/Python version information:

Bug present in HEAD:

1.0.0 1.14.1 sys.version_info(major=3, minor=6, micro=4, releaselevel='final', serial=0)
@batterseapower
Copy link
Contributor Author

Maybe we should resurrect the code in #1240 instead

pv pushed a commit to batterseapower/scipy that referenced this issue May 5, 2018
@pv pv added this to the 1.2.0 milestone May 5, 2018
@pv
Copy link
Member

pv commented May 5, 2018

gh-8740

@pv pv closed this as completed May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants