Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: optimize: tweaked linprog status 4 error message #10025

Merged
merged 1 commit into from Apr 12, 2019

Conversation

mdhaber
Copy link
Contributor

@mdhaber mdhaber commented Apr 8, 2019

Method interior-point sometimes terminates successfully without
satisfying the original constraints within required tolerances.
This revised error message gives suggestions for dealing
with this situation.

Method `interior-point` sometimes terminates successfully without
satisfying the original constraints within required tolerances.
This revised error message gives suggestions for dealing
with this situation.
@mdhaber
Copy link
Contributor Author

mdhaber commented Apr 8, 2019

See #9671. Old error message:
The solution does not satisfy the constraints, yet no errors were raised and there is no certificate of infeasibility or unboundedness. This is known to occur if the presolve option is False and the problem is infeasible. If you encounter this under different circumstances, please submit a bug report. Otherwise, please enable presolve.
Now:
The solution does not satisfy the constraints within the required tolerance of 3.16E-04, yet no errors were raised and there is no certificate of infeasibility or unboundedness. This is known to occur if the presolveoption is False and the problem is infeasible. This can also occur due to the limited accuracy of theinterior-pointmethod. Check whether the slack and constraint residuals are acceptable; if not, consider enabling presolve, reducing optiontol, and/or using method revised simplex. If you encounter this message under different circumstances, please submit a bug report.

@mdhaber mdhaber requested a review from Kai-Striega April 8, 2019 00:09
@ilayn
Copy link
Member

ilayn commented Apr 8, 2019

If I receive this error three times in a row it would be quite clunky. I would suggest pushing the explanation to notes or docstring and leave the prompt as short as possible. Error codes are also annoying to lookup everytime but I think there can be some compromise between two ends of the spectrum.

Nevermind I thought this is the message that is printed to the console.

Copy link
Member

@Kai-Striega Kai-Striega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Stating the tolerance used is also a good idea, as this will be different to the tol parameter passed by the user.

@Kai-Striega Kai-Striega added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.optimize labels Apr 8, 2019
@rgommers rgommers merged commit 6e9ea2f into scipy:master Apr 12, 2019
@rgommers
Copy link
Member

LGTM too, in it goes. Thanks @mdhaber

@rgommers rgommers added this to the 1.3.0 milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants