TST: make a couple of tests expected to fail on 32-bit architectures #12899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbell10
reviewed
Sep 30, 2020
Comment on lines
64
to
65
| @pytest.mark.skipif(not (sys.platform.startswith('linux') and np.dtype(np.intp).itemsize >= 8), | ||
| reason="test requires 64-bit Linux") |
There was a problem hiding this comment.
Can you use @pytest.mark.xfail_on_32bit?
There was a problem hiding this comment.
Done. I used the same message as with TestConvolve2d.test_large_array, I think it fits.
nforro
force-pushed
the
test_nnz_overflow
branch
2 times, most recently
from
ff7809b to
5272a5a
Compare
nforro
changed the title
nforro
force-pushed
the
test_nnz_overflow
branch
from
5272a5a to
ea0a77c
Compare
nforro
changed the title
|
I've just discovered that |
|
@nforro CI was badly broken yesterday. Would you mind rebasing on master so we can see CI run. |
In TestConstructUtils.test_concatenate_int32_overflow and test_nnz_overflow, on a 32-bit architecture, in case check_free_memory() passes, ValueError is raised on an attempt to create a numpy array too large for a 32-bit architecture. Signed-off-by: Nikola Forró <nforro@redhat.com>
nforro
force-pushed
the
test_nnz_overflow
branch
from
ea0a77c to
7736712
Compare
peterbell10
approved these changes
Oct 1, 2020
|
Thanks @nforro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
TestConstructUtils.test_concatenate_int32_overflowandtest_nnz_overflow, on a 32-bit architecture, in casecheck_free_memory()passes,ValueErroris raised on an attempt to create a numpy array too large for a 32-bit architecture.