Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove 'env' from pytest.ini #12902

Merged
merged 1 commit into from Oct 1, 2020
Merged

Conversation

WarrenWeckesser
Copy link
Member

No description provided.

@WarrenWeckesser
Copy link
Member Author

WarrenWeckesser commented Sep 30, 2020

This fixes the error that we've been getting with pytest 6.0 in recent PRs.

The cancelled Azure run, "scipy.scipy (Windows Python36-32bit-fast)", is weird. It appears to be a leftover from a previous run of the test suite. I closed and opened the PR, and the tests ran again, but that cancelled item remained in the list. Note that there is another entry for "scipy.scipy (Windows Python36-32bit-fast)" that has passed.

I haven't figured out the cause of the Travis CI failure for the platform AMD64 / xenial / "Wheel, Optimised, GCC 4.8". The end of the log says

pytest.PytestConfigWarning: assertions not in test modules or plugins will be ignored because assert statements are not executed by the underlying Python interpreter (are you using python -O?)

That test runs with the environment variable PYTHONOPTIMIZE=2.

@WarrenWeckesser
Copy link
Member Author

The Travis CI failure on AMD64 / xenial / "Wheel, Optimised, GCC 4.8" has occurred on other recent PRs (e.g. #12889 and #12899), so it is not related to this PR. I'm moving this PR out of "draft" mode, as it fixes multiple failures being caused by a change in python 6.0. We can deal with the remaining failure in a separate PR.

@WarrenWeckesser WarrenWeckesser marked this pull request as ready for review October 1, 2020 00:41
@sethtroisi
Copy link
Contributor

@WarrenWeckesser Merging so we can unblock large number of other PRs.

It does seem like we should potentially add PYTHONHASHSEED=0 back using some other mechanism

@WarrenWeckesser WarrenWeckesser added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Oct 1, 2020
@sethtroisi sethtroisi merged commit 5f4c4d8 into scipy:master Oct 1, 2020
@WarrenWeckesser WarrenWeckesser deleted the pytest-env branch October 1, 2020 00:48
@WarrenWeckesser WarrenWeckesser added this to the 1.6.0 milestone Oct 1, 2020
@rlucas7 rlucas7 mentioned this pull request Oct 2, 2020
8 tasks
@tylerjereddy tylerjereddy added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 8, 2020
@tylerjereddy
Copy link
Contributor

This needs to be backported to gh-12906 based on CI fails there, so proceeding with that

@tylerjereddy tylerjereddy modified the milestones: 1.6.0, 1.5.3 Oct 8, 2020
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants