Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
BUG: signal: lfilter would segfault on object arrays (ticket #1452) #131
There are some memory leaks that can occur as a result of error conditions. I've noted some with line notes in the diff.
I don't see how to comment on lines that aren't part of a commit, so here are additional notes about lfilter.c.src. The line numbers refer to commit a079e11:
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Just noticed one more missing check of a return value in scipy_signal_sigtools_linear_filter(): after creating arVf in lines 127-129, a check for NULL is needed. It looks like the same check as the others is sufficient, e.g.
(Isn't C fun?)
Also, there a couple tabs instead of spaces in the beginning of line 579.
(Line numbers refer to 202b5ac)