MAINT: backports for 1.7.2, plus update Pythran min version to 0.9.12 #14937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[azure skip] [circle skip] (cherry picked from commit 48e1dd7)
* MAINT: disable include/source coverage warning. Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com> (cherry picked from commit 5938242)
(cherry picked from commit 95fc039)
(cherry picked from commit cd1c680)
* Added missing np.import_array() In principle this should always be called before using cimported Numpy from Cython files. It becomes more important on recent versions of Cython (since they use the Numpy API rather than directly looking into the objects) * Remove version pin * Added some missing lines in templ files (cherry picked from commit 2f4bd42)
This gets rid of the NetworkX dependency in Pythran, which was removed in 0.9.12 Closes scipygh-14335
rgommers
added
Build issues
rgommers
requested review from
andyfaff,
ev-br,
ilayn,
larsoner,
peterbell10,
tupui and
tylerjereddy
as code owners
|
The macOS is still unhappy, but only because of: which is present in master as well. The build failure we saw in the last PR to the 1.7.x branch is resolved. |
tupui
approved these changes
Oct 29, 2021
tylerjereddy
approved these changes
Oct 29, 2021
|
ok, the backport slate should be "clean" and re-milestoned now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the five backports that were in the queue, plus one commit specific to 1.7.x to update the minimum Pythran version we build with.
That version bump gets rid of the NetworkX dependency in Pythran, which was removed in 0.9.12. Closes gh-14335
This should also fix all CI failures on the 1.7.x branch.