TST: silence test failures on macOS for beta.ppf overflow
#14938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See scipygh-14901 for details. [skip azp] [skip github]
rgommers
added
scipy.stats
maintenance
| @@ -37,6 +37,10 @@ | |||
| # python -OO strips docstrings | |||
| DOCSTRINGS_STRIPPED = sys.flags.optimize > 1 | |||
|
|
|||
| # Failing on macOS 11, Intel CPUs. See gh-14901 | |||
| MACOS_INTEL = (sys.platform == 'darwin') and (platform.machine() == 'x86_64') | |||
There was a problem hiding this comment.
I think we need to add import platform above--let me see if I can push that in real quick
* add missing `platform` import
| @@ -2879,6 +2886,7 @@ def test_issue_12796(self): | |||
| res = stats.beta.cdf(inv, a, b) | |||
| assert_allclose(res, 1 - alpha_2) | |||
|
|
|||
| @pytest.mark.skipif(MACOS_INTEL, reason="Overflow, see gh-14901") | |||
There was a problem hiding this comment.
I thought the third failing test was test_issue_12635 above, unless I'm misreading the diff
FAILED scipy/stats/tests/test_distributions.py::TestBeta::test_issue_12635 - ...
FAILED scipy/stats/tests/test_distributions.py::TestBeta::test_issue_12794 - ...
FAILED scipy/stats/tests/test_distributions.py::TestBeta::test_issue_12796 - ...
There was a problem hiding this comment.
I went ahead and pushed that in--probably just some speedy copy-paste work.
* fix up the third skipped test to match what CI is complaining about
|
I'll go ahead and squash merge since the MacOS CI entries are now passing and my correction commits hardly need to be separated for this temporary bypass PR. |
|
Thanks Tyler! |
tylerjereddy
removed
the
backport-candidate
tylerjereddy
added a commit
to tylerjereddy/scipy
that referenced
this pull request
Nov 5, 2021
) * TST: silence test failures on macOS for `beta.ppf` overflow See scipygh-14901 for details. [skip azp] [skip github] Co-authored-by: Tyler Reddy <tyler.je.reddy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gh-14901 for details.
[skip azp]
[skip github]