Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: 1.7.3 backports/doc updates #15088

Merged
merged 4 commits into from
Nov 24, 2021
Merged

MAINT: 1.7.3 backports/doc updates #15088

merged 4 commits into from
Nov 24, 2021

Conversation

tylerjereddy
Copy link
Contributor

  • add early draft of the release notes for SciPy 1.7.3.--I'm not actually sure how many problematic tests are going to be skipped, but I've left a sentence in there about test skipping for the arm64 thin wheels
  • I've manually added an author or two based on assistance with M1 wheels work that would not get picked up by our script--feel free to suggest others if appropriate
  • there's really very little in the area of backports here at the moment--most of the magic was in the wheels repo, and I think we may get some test skips added from Ralf for this maintenance branch for which I'd then update this PR

@tylerjereddy tylerjereddy added the maintenance Items related to regular maintenance tasks label Nov 23, 2021
@tylerjereddy tylerjereddy added this to the 1.7.3 milestone Nov 23, 2021
@tylerjereddy
Copy link
Contributor Author

Ah, I see the deprecation warnings in there.. I guess we should try to patch that one way or another.

The default_rng thing from @tupui is probably because we have a lower minimum NumPy for the maintenance branch--can we use an old school seed approach here? Or even just be lazy and skip that test on older NumPy?

@rgommers
Copy link
Member

Or even just be lazy and skip that test on older NumPy?

Yes, just skip the test I'd say.

@tupui
Copy link
Member

tupui commented Nov 23, 2021

Ah right yes, sorry about that. It's really fine to skip indeed.

Just a side note. I noticed I missed to update the main __init__.py minimal NumPy version. But not sure this is used.

tupui and others added 4 commits November 23, 2021 18:09
@tupui @99991 @tylerjereddy
BUG: out of bounds indexing in stats.qmc.update_discrepancy.
4f14791 
Co-authored-by: 99991 <99991@users.noreply.github.com>
@tylerjereddy
DOC: draft 1.7.3 release notes
759f76e
@tylerjereddy
MAINT: PR 15088 revisions
20c42c2 
* add Isuru Fernando to author list, for assistance in
providing M1 support

* adjust the 1.7.3 release notes summary to remove any
mention of test skips and to note that MacOS version 12.0
is required for the arm64 wheels.

* skip a `qmc` test when it is executed with a version
of NumPy < 1.17, because default_rng not available
@tylerjereddy
DOC: update 1.7.3 relnotes.
7275c59
@tylerjereddy
Copy link
Contributor Author

If the CI continues to only have an issue with super-recent NumPy deprecation warnings, I'll proceed with a merge and the initiation of the release process.

@tylerjereddy tylerjereddy merged commit 9fcfc45 into scipy:maintenance/1.7.x Nov 24, 2021
@tylerjereddy tylerjereddy deleted the treddy_backports_173 branch November 24, 2021 04:27
@tylerjereddy
Copy link
Contributor Author

1.7.3 wheel builds have been started.. I'll aim to continue the release process tomorrow barring any major problems

@rgommers
Copy link
Member

Awesome, thanks Tyler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers left review comments

Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerjereddy @rgommers @tupui