BLD: Fix Bento build of source distribution #158

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

scottza commented Feb 14, 2012

  • Several files required to build Scipy using Bento are not included
    in source distributions created using python setup.py sdist.
BLD: Fix Bento build of source distribution
* Several files required to build Scipy using Bento are not included
  in source distributions created using `python setup.py sdist`.
MANIFEST.in
+include interface_gen.py
+include bscript bento.info
+recursive-include scipy bscript bento.info
+include scipy/special/tests/*.dat
@pv

pv Feb 14, 2012

Owner

I think the last line isn't needed -- there's nothing in those data files. They probably should be removed, actually...

@scottza

scottza Feb 15, 2012

Contributor

The last line prevents a build failure with the following message:

bentomaker: Error: bentomaker crashed (uncaught exception <type 'exceptions.IOError'>:
File/glob special/tests/*.dat could not be resolved (data file section tests)).

The data files don't look empty to me?

@rgommers

rgommers Feb 18, 2012

Owner

The files are not empty, but after removing them all tests still pass. They're not used.

How about removing those .dat files and fixing the Bento error by removing line 73 in the top-level bento.info file? Can you confirm that that works Scott?

@scottza

scottza Feb 19, 2012

Contributor

Yes - that works fine. I've pushed a new commit with your suggested change.

Owner

pv commented Feb 14, 2012

Yep. Probably also needs to go in 0.10.1, as the bento stuff doesn't seem to be included in the tarballs.

Contributor

scottza commented Feb 16, 2012

Just a heads up that I get some test failures related to undefined Fortran symbols after building and installing with Bento.

As it stands this change only lets the build proceed without errors..

Owner

rgommers commented Feb 18, 2012

Can you open a ticket for the test failures, or report them on the list?

Owner

rgommers commented Feb 18, 2012

An update of BENTO_BUILD.txt also wouldn't hurt. I can't actually make it work right now.

Owner

rgommers commented Feb 19, 2012

If one of you has any time today to try my suggested change above, that would be great. I would like to get 0.10.1rc2 out the door tonight.

Contributor

scottza commented Feb 19, 2012

I'll report the build failures on the list and have a go at improving BENTO_BUILD.txt, but don't have time to do that today.

Owner

rgommers commented Feb 19, 2012

Thanks Scott. I've merged this in 759eda9 and removed the .dat files in 785a822. I'll backport the first commit to 0.10.x.

@rgommers rgommers closed this Feb 19, 2012

Owner

rgommers commented Feb 19, 2012

I think the more detailed instructions and better testing with Bento will have to wait till 0.11.

Owner

pv commented Feb 19, 2012

The issue seems to be that _cephes.so should be linked with the Fortran compiler, even though it has no Fortran source files. Unfortunately, I have no idea how to tell the waf/bento combination to do that...

Owner

rgommers commented Feb 19, 2012

No idea either. I don't see anything to that effect in setup.py or SConscript though. What am I missing?

Owner

pv commented Feb 19, 2012

Ok, the problem is a link flag order issue; '-lgfortran' should come after '-lsc_*', not before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment