DOC: Add efficiency condition for CSC sparse matrix and remove CSC warning. #15846
Conversation
|
I'd prefer to keep the warning and update the documentation to say that CSC format is preferred/expected (and drop the mention of CSR). We should also reword the warning to say something like: The idea here is that we want users to know when sparse format conversions are happening under the hood, so they can make informed decisions about which format to use for their application code. |
There was a problem hiding this comment.
See my comment #15846 (comment)
Should be sufficient to remove the mention of CSR format in the docstrings, and edit the warning message.
…nvey that CSC is the most efficient sparse matrix format. change warning for splu DOC: Change documentation of sparse solvers and warnings to better convey that CSC is the most efficient sparse matrix format. update warning message update comment remove brackets
|
@v0dro this looks ready, but is still marked as Draft - any reason to not merge this as is? |
There was a problem hiding this comment.
LGTM now, thanks @ v0dro. And thanks @perimosocordiae for the review.
Closes gh-11145. Remove warnings for efficiency when using CSC matrices.